Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-2186) - Aria label input for generic link #18520

Merged
merged 14 commits into from
Mar 29, 2024
Merged

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Feb 20, 2024

https://jira.tools.sap/browse/CXSPA-2186

I have added an optional input for the generic link. It allows us to set a more relevant content for screen readers to read out.
It should not need feature flags.

@Pio-Bar Pio-Bar requested a review from a team as a code owner February 20, 2024 12:39
@github-actions github-actions bot marked this pull request as draft February 20, 2024 12:39
@Pio-Bar Pio-Bar marked this pull request as ready for review February 20, 2024 12:41
Copy link

cypress bot commented Feb 20, 2024

3 flaky tests on run #43169 ↗︎

0 119 2 0 Flakiness 3
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 453464f into d15244a...
Project: spartacus Commit: c7347834a6 ℹ️
Status: Passed Duration: 12:22 💡
Started: Mar 29, 2024 9:14 AM Ended: Mar 29, 2024 9:26 AM

Review all test suite changes for PR #18520 ↗︎

rmch91
rmch91 previously approved these changes Feb 21, 2024
@github-actions github-actions bot marked this pull request as draft February 26, 2024 15:50
@Pio-Bar Pio-Bar requested a review from rmch91 February 26, 2024 15:52
@Pio-Bar Pio-Bar marked this pull request as ready for review February 26, 2024 15:52
@github-actions github-actions bot marked this pull request as draft February 26, 2024 16:06
@Pio-Bar Pio-Bar marked this pull request as ready for review February 26, 2024 16:45
rmch91
rmch91 previously approved these changes Feb 28, 2024
developpeurweb
developpeurweb previously approved these changes Mar 12, 2024
Copy link
Contributor

@developpeurweb developpeurweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with JAWS/VO. Tested with AMP, no issues found.

@Pio-Bar Pio-Bar dismissed stale reviews from developpeurweb and rmch91 via 9eabb90 March 27, 2024 12:55
@github-actions github-actions bot marked this pull request as draft March 27, 2024 12:56
@Pio-Bar Pio-Bar marked this pull request as ready for review March 27, 2024 14:57
@github-actions github-actions bot marked this pull request as draft March 27, 2024 15:11
@Pio-Bar Pio-Bar marked this pull request as ready for review March 27, 2024 16:21
@github-actions github-actions bot marked this pull request as draft March 27, 2024 16:48
@Pio-Bar Pio-Bar marked this pull request as ready for review March 28, 2024 10:05
@github-actions github-actions bot marked this pull request as draft March 28, 2024 10:34
@Pio-Bar Pio-Bar marked this pull request as ready for review March 28, 2024 11:03
@github-actions github-actions bot marked this pull request as draft March 29, 2024 08:39
@Pio-Bar Pio-Bar marked this pull request as ready for review March 29, 2024 09:05
@Pio-Bar Pio-Bar merged commit aff4e65 into develop Mar 29, 2024
26 checks passed
@Pio-Bar Pio-Bar deleted the feature/CXSPA-2186 branch March 29, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants