feat: (CXSPA-981) - Add keyboard navigation to 'navigation-ui' #18297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeyber
requested changes
Dec 22, 2023
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.ts
Outdated
Show resolved
Hide resolved
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.ts
Outdated
Show resolved
Hide resolved
4 flaky tests on run #43069 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Checkout flow > Desktop > should checkout with a registered user by searching a product |
Test Replay
Screenshots
Video
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #18297 ↗︎
Zeyber
requested changes
Jan 8, 2024
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.ts
Outdated
Show resolved
Hide resolved
added 6 commits
January 19, 2024 15:11
Pio-Bar
force-pushed
the
feature/CXSPA-981
branch
from
c18de33 to
f740f75
Compare
Zeyber
requested changes
Jan 22, 2024
projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/aux-key.e2e.cy.ts
Outdated
Show resolved
Hide resolved
projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/keyboard-navigation.e2e.cy.ts
Outdated
Show resolved
Hide resolved
projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/keyboard-navigation.e2e.cy.ts
Show resolved
Hide resolved
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.html
Outdated
Show resolved
Hide resolved
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.html
Outdated
Show resolved
Hide resolved
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.ts
Show resolved
Hide resolved
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.ts
Show resolved
Hide resolved
Pio-Bar
changed the title
added 2 commits
March 15, 2024 10:19
Zeyber
previously approved these changes
Mar 21, 2024
| @@ -5,11 +5,11 @@ | |||
| */ | |||
|
|
|||
| import { SchematicsException } from '@angular-devkit/schematics'; | |||
There was a problem hiding this comment.
Lets undo these changes not to mix up our commit.
Zeyber
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.tools.sap/browse/CXSPA-981
Because of the recursive approach to navigation, the keyboard controls have proven to be quite tricky to implement. If you find a more elegant approach I'd be happy to know.