CXSPA-5174 #18030
Merged
CXSPA-5174 #18030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anjana-bl
commented
Oct 29, 2023
anjana-bl
commented
- fixing alignment issue in Landing Page
- Altering font size in landing page
- renaming injection token MY_ACCOUNT_V2_ORDER to USE_MY_ACCOUNT_V2_ORDER
4 flaky tests on run #41783 ↗︎
Details:
|
|||||||||||||||
Platonn
approved these changes
Oct 30, 2023
Platonn
reviewed
Oct 30, 2023
Comment on lines
+11
to
+16
| float: left; | ||
| max-width: 25%; | ||
| @include media-breakpoint-down(md) { | ||
| width: 100%; | ||
| max-width: none; | ||
| } | ||
| } | ||
|
|
||
| .RightContentSlot { | ||
| float: left; |
There was a problem hiding this comment.
[NITPICK]
Do we really have to use float instead of flex for styling %MyAccountViewPageTemplate? I believe for consistency with the rest of the project, it would be good to stick to flex styling.
I can see float is used also in other files in my-account-v2 area. Perhaps it would be good to fix it before 6.6 release:
(yes, I can see float is used also in ASM, which ideally should have used flex)
Platonn
reviewed
Oct 30, 2023
There was a problem hiding this comment.
- ✅ Approving changes to
MY_ACCOUNT_V2_ORDER->USE_MY_ACCOUNT_V2_ORDER - Nitpick: IMHO the CSS changes should be done in a different PR, for clarity of git history
- I don't have access to your env, so please do the QA of the styling changes in with the help of sb in your team (including cross-browsers & screen width testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.