Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add SPA version when requesting features #18015

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: add SPA version when requesting features #18015

merged 1 commit into from
Oct 25, 2023

Conversation

ChristophHi
Copy link
Contributor

No description provided.

@ChristophHi ChristophHi requested a review from a team as a code owner October 25, 2023 08:16
@github-actions github-actions bot marked this pull request as draft October 25, 2023 08:16
@ChristophHi ChristophHi marked this pull request as ready for review October 25, 2023 08:25
@cypress
Copy link

cypress bot commented Oct 25, 2023

4 flaky tests on run #41732 ↗︎

0 119 2 0 Flakiness 4

Details:

Merge a9fc5dc into 720b0a4...
Project: spartacus Commit: 2d36e42ff4 ℹ️
Status: Passed Duration: 06:11 💡
Started: Oct 25, 2023 8:39 AM Ended: Oct 25, 2023 8:46 AM
Flakiness  regression/asm/asm.deeplink.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Assisted Service Module > Customer Support Agent - Emulation&deeplink > should emulate customer and navigate to saved cart with deeplink after agent login (CXSPA-3263) Test Replay Output Screenshots Video
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Output Screenshots Video
SSR > should render PLP Test Replay Output Screenshots Video
SSR > should render PDP Test Replay Output Screenshots Video

Review all test suite changes for PR #18015 ↗︎

@ChristophHi ChristophHi merged commit 29fd483 into develop-6.6.x Oct 25, 2023
22 checks passed
@ChristophHi ChristophHi deleted the fix/CXSPA-5131-fix-spa-version branch October 25, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Platonn Platonn Platonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophHi @Platonn