Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: component with restriction is not displayed after changed in SmartEdit #17893

Merged
merged 10 commits into from
Oct 6, 2023
Merged

fix: component with restriction is not displayed after changed in SmartEdit #17893

merged 10 commits into from
Oct 6, 2023

Conversation

FollowTheFlo
Copy link
Contributor

@FollowTheFlo FollowTheFlo commented Sep 29, 2023 •
edited
Loading

CXSPA-3495
Add 2 parameters in query url when loading ProductList page.

@FollowTheFlo FollowTheFlo requested a review from a team as a code owner September 29, 2023 21:31
@github-actions github-actions bot marked this pull request as draft September 29, 2023 21:31
@FollowTheFlo FollowTheFlo changed the base branch from develop-6.5.x to develop-6.6.x October 2, 2023 16:48
@FollowTheFlo FollowTheFlo marked this pull request as ready for review October 5, 2023 13:36
@github-actions github-actions bot marked this pull request as draft October 5, 2023 13:37
@FollowTheFlo FollowTheFlo marked this pull request as ready for review October 5, 2023 14:17
@github-actions github-actions bot marked this pull request as draft October 5, 2023 14:39
@FollowTheFlo FollowTheFlo marked this pull request as ready for review October 5, 2023 15:36
@github-actions github-actions bot marked this pull request as draft October 5, 2023 16:16
@FollowTheFlo FollowTheFlo marked this pull request as ready for review October 6, 2023 02:51
@github-actions github-actions bot marked this pull request as draft October 6, 2023 03:11
@FollowTheFlo FollowTheFlo marked this pull request as ready for review October 6, 2023 03:14
@cypress
Copy link

cypress bot commented Oct 6, 2023 •
edited
Loading

4 flaky tests on run #41594 ↗︎

0 119 2 0 Flakiness 4

Details:

Merge e3aef2f into 19d4559...
Project: spartacus Commit: 82e345b3c1 ℹ️
Status: Passed Duration: 06:00 💡
Started: Oct 6, 2023 2:13 PM Ended: Oct 6, 2023 2:19 PM
Flakiness  regression/asm/asm.deeplink.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Assisted Service Module > Customer Support Agent - Emulation&deeplink > should emulate customer and navigate to support ticket with deeplink after agent login (CXSPA-3263) Test Replay Output Screenshots Video
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Output Screenshots Video
SSR > should render PLP Test Replay Output Screenshots Video
SSR > should render PDP Test Replay Output Screenshots Video

Review all test suite changes for PR #17893 ↗︎

@github-actions github-actions bot marked this pull request as draft October 6, 2023 13:56
@FollowTheFlo FollowTheFlo marked this pull request as ready for review October 6, 2023 13:58
@FollowTheFlo FollowTheFlo merged commit 0d36166 into develop-6.6.x Oct 6, 2023
@FollowTheFlo FollowTheFlo deleted the feature/CXSPA-3495 branch October 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmch91 rmch91 rmch91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FollowTheFlo @rmch91