Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: package update #17818

Merged
merged 16 commits into from
Sep 14, 2023
Merged

chore: package update #17818

merged 16 commits into from
Sep 14, 2023

Conversation

kpawelczak
Copy link
Contributor

No description provided.

@kpawelczak kpawelczak requested a review from a team as a code owner September 11, 2023 07:02
@kpawelczak kpawelczak requested a review from a team September 11, 2023 07:02
@kpawelczak kpawelczak requested review from a team as code owners September 11, 2023 07:02
@github-actions github-actions bot marked this pull request as draft September 11, 2023 07:02
@kpawelczak kpawelczak marked this pull request as ready for review September 11, 2023 14:30
@cypress
Copy link

cypress bot commented Sep 11, 2023 •
edited
Loading

5 flaky tests on run #41395 ↗︎

0 119 2 0 Flakiness 5

Details:

Merge cebe2d8 into b5f836a...
Project: spartacus Commit: a677a541f8 ℹ️
Status: Passed Duration: 08:29 💡
Started: Sep 14, 2023 11:09 PM Ended: Sep 14, 2023 11:18 PM
Flakiness  regression/asm/asm.deeplink.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Assisted Service Module > Customer Support Agent - Emulation&deeplink > should emulate customer and navigate to support ticket with deeplink after agent login (CXSPA-3263) Test Replay Output Screenshots Video
Flakiness  regression/checkout/checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Checkout flow > Mobile > should checkout with a registered user Test Replay Output Screenshots Video
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Output Screenshots Video
SSR > should render PLP Test Replay Output Screenshots Video
SSR > should render PDP Test Replay Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions github-actions bot marked this pull request as draft September 11, 2023 15:05
@kpawelczak kpawelczak marked this pull request as ready for review September 11, 2023 16:18
@github-actions github-actions bot marked this pull request as draft September 12, 2023 07:33
@kpawelczak kpawelczak marked this pull request as ready for review September 12, 2023 08:48
@github-actions github-actions bot marked this pull request as draft September 14, 2023 13:30
giancorderoortiz
giancorderoortiz previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@giancorderoortiz giancorderoortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For compliance with SDOL-005.
One additional dev approval should be given before merging.

@giancorderoortiz giancorderoortiz marked this pull request as ready for review September 14, 2023 22:14
@github-actions github-actions bot marked this pull request as draft September 14, 2023 22:51
@giancorderoortiz giancorderoortiz marked this pull request as ready for review September 14, 2023 22:54
giancorderoortiz
giancorderoortiz approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@giancorderoortiz giancorderoortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For compliance with SDOL-005

@giancorderoortiz giancorderoortiz merged commit 30e51f8 into develop-6.5.x Sep 14, 2023
@giancorderoortiz giancorderoortiz deleted the feat/CXSPA-4633-package-update branch September 14, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giancorderoortiz giancorderoortiz giancorderoortiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpawelczak @giancorderoortiz