Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 13807 layout changes #13949

Merged
merged 10 commits into from
Oct 5, 2021
Merged

Conversation

ChristophHi
Copy link
Contributor

No description provided.

@ChristophHi ChristophHi temporarily deployed to dev October 4, 2021 06:27 Inactive
@ChristophHi ChristophHi temporarily deployed to dev October 4, 2021 06:56 Inactive
@cypress
Copy link

cypress bot commented Oct 4, 2021



Test summary

638 0 13 0Flakiness 4


Run details

Project spartacus
Status Passed
Commit dc2207d ℹ️
Started Oct 5, 2021 4:56 AM
Ended Oct 5, 2021 5:12 AM
Duration 15:48 💡
OS Linux Ubuntu - 18.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

regression/coupons/coupons.e2e-spec.ts Flakiness
1 Cart Coupon > Mobile > should apply cart coupon
ssr/pages.e2e-spec.ts Flakiness
1 SSR > should render homepage
2 SSR > should render PLP
3 SSR > should render PDP

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Larisa-Staroverova Larisa-Staroverova self-requested a review October 4, 2021 08:05
Copy link
Contributor

@Larisa-Staroverova Larisa-Staroverova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see my comment. It is a suggestion.

@ChristophHi ChristophHi temporarily deployed to dev October 4, 2021 14:32 Inactive
@ChristophHi ChristophHi temporarily deployed to dev October 5, 2021 04:45 Inactive
@ChristophHi ChristophHi merged commit bd79df1 into develop Oct 5, 2021
@ChristophHi ChristophHi deleted the feature/GH-13807-layout-changes branch October 5, 2021 05:35
@ChristophHi ChristophHi temporarily deployed to dev October 5, 2021 05:35 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Public API changes

⚠️ @spartacus/product-configurator/rulebased/root

 }
 
 // @public
+export class CpqConfiguratorLayoutModule {
+    // (undocumented)
+    static ɵfac: i0.ɵɵFactoryDeclaration<CpqConfiguratorLayoutModule, never>;
+    // (undocumented)
+    static ɵinj: i0.ɵɵInjectorDeclaration<CpqConfiguratorLayoutModule>;
+    // (undocumented)
+    static ɵmod: i0.ɵɵNgModuleDeclaration<CpqConfiguratorLayoutModule, never, never, never>;
+}
+
+// @public
 export class CpqConfiguratorOverviewModule {
     // (undocumented)
     static ɵfac: i0.ɵɵFactoryDeclaration<CpqConfiguratorOverviewModule, never>;
@@
 }
 
 // @public
+export class VariantConfiguratorInteractiveLayoutModule {
+    // (undocumented)
+    static ɵfac: i0.ɵɵFactoryDeclaration<VariantConfiguratorInteractiveLayoutModule, never>;
+    // (undocumented)
+    static ɵinj: i0.ɵɵInjectorDeclaration<VariantConfiguratorInteractiveLayoutModule>;
+    // (undocumented)
+    static ɵmod: i0.ɵɵNgModuleDeclaration<VariantConfiguratorInteractiveLayoutModule, never, never, never>;
+}
+
+// @public
 export class VariantConfiguratorInteractiveModule {
     // (undocumented)
     static ɵfac: i0.ɵɵFactoryDeclaration<VariantConfiguratorInteractiveModule, never>;
@@
 }
 
 // @public
+export class VariantConfiguratorOverviewLayoutModule {
+    // (undocumented)
+    static ɵfac: i0.ɵɵFactoryDeclaration<VariantConfiguratorOverviewLayoutModule, never>;
+    // (undocumented)
+    static ɵinj: i0.ɵɵInjectorDeclaration<VariantConfiguratorOverviewLayoutModule>;
+    // (undocumented)
+    static ɵmod: i0.ɵɵNgModuleDeclaration<VariantConfiguratorOverviewLayoutModule, never, never, never>;
+}
+
+// @public
 export class VariantConfiguratorOverviewModule {
     // (undocumented)
     static ɵfac: i0.ɵɵFactoryDeclaration<VariantConfiguratorOverviewModule, never>;

⚠️ Some entry points are currently impossible to analyze.

Read more

💰 How to debug problems?

Read more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean Header on Configuration Page that only the relevant CMS Components are shown
2 participants