Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/GH11461: Add error message when removing required attribute #12929

Merged
merged 23 commits into from
Jun 30, 2021
Merged

Feature/GH11461: Add error message when removing required attribute #12929

merged 23 commits into from
Jun 30, 2021

Conversation

Changsuwan
Copy link
Contributor

No description provided.

@Changsuwan Changsuwan linked an issue Jun 24, 2021 that may be closed by this pull request
User should be informed if it's not possible to remove bundle product #11461
Closed
@cypress
Copy link

cypress bot commented Jun 24, 2021 •
edited
Loading


Test summary

165 • 0 • 1 • 0 • Flakiness 0

Run details
Project spartacus
Status Passed
Commit c0221d3 ℹ️
Started Jun 30, 2021 5:45 AM
Ended Jun 30, 2021 5:59 AM
Duration 13:38 💡
OS Linux Ubuntu - 18.04
Browser Electron 89

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

ChristophHi
ChristophHi requested changes Jun 25, 2021
View reviewed changes
...ased/components/attribute/product-card/configurator-attribute-product-card.component.spec.ts Outdated Show resolved Hide resolved
...rulebased/components/attribute/product-card/configurator-attribute-product-card.component.ts Outdated Show resolved Hide resolved
...rulebased/components/attribute/product-card/configurator-attribute-product-card.component.ts Outdated Show resolved Hide resolved
...rulebased/components/attribute/product-card/configurator-attribute-product-card.component.ts Outdated
@@ -116,9 +122,18 @@ export class ConfiguratorAttributeProductCardComponent

onHandleDeselect(): void {
this.loading$.next(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, loading must not be emitted here! Otherwise it's e.g. not possible to change qty when the error message is visible.
Please emit loading only after you checked that the product can really be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

feature-libs/product-configurator/rulebased/styles/_configurator-attribute-product-card.scss Show resolved Hide resolved
@Changsuwan @ChristophHi
Update feature-libs/product-configurator/rulebased/components/attribu…
6a6982e 
…te/product-card/configurator-attribute-product-card.component.ts

Co-authored-by: Christoph Hinssen <[email protected]>
@Changsuwan @ChristophHi
Update feature-libs/product-configurator/rulebased/components/attribu…
1e34bb9 
…te/product-card/configurator-attribute-product-card.component.ts

Co-authored-by: Christoph Hinssen <[email protected]>
@Changsuwan @ChristophHi
Update feature-libs/product-configurator/rulebased/components/attribu…
a24ebbf 
…te/product-card/configurator-attribute-product-card.component.spec.ts

Co-authored-by: Christoph Hinssen <[email protected]>
@Changsuwan Changsuwan temporarily deployed to dev June 25, 2021 09:09 Inactive
@Changsuwan Changsuwan temporarily deployed to dev June 25, 2021 09:09 Inactive
@Changsuwan Changsuwan temporarily deployed to dev June 25, 2021 09:28 Inactive
@ChristophHi ChristophHi temporarily deployed to dev June 25, 2021 12:54 Inactive
@Changsuwan Changsuwan temporarily deployed to dev June 25, 2021 13:44 Inactive
ChristophHi
ChristophHi previously approved these changes Jun 28, 2021
View reviewed changes
@ChristophHi ChristophHi temporarily deployed to dev June 28, 2021 05:21 Inactive
@Changsuwan Changsuwan temporarily deployed to dev June 28, 2021 09:00 Inactive
ChristophHi
ChristophHi previously approved these changes Jun 28, 2021
View reviewed changes
@Changsuwan Changsuwan temporarily deployed to dev June 28, 2021 13:21 Inactive
@ChristophHi ChristophHi temporarily deployed to dev June 28, 2021 14:15 Inactive
@Changsuwan Changsuwan temporarily deployed to dev June 29, 2021 06:32 Inactive
@Changsuwan Changsuwan temporarily deployed to dev June 29, 2021 08:21 Inactive
@Changsuwan Changsuwan temporarily deployed to dev June 29, 2021 09:19 Inactive
@ChristophHi ChristophHi temporarily deployed to dev June 29, 2021 14:29 Inactive
@ChristophHi ChristophHi temporarily deployed to dev June 30, 2021 04:33 Inactive
@ChristophHi ChristophHi temporarily deployed to dev June 30, 2021 05:06 Inactive
@github-actions
Copy link
Contributor

Hosting service deployment

🚀 Spartacus deployed to https://dmg46jsd3n6v6.cloudfront.net

@ChristophHi ChristophHi merged commit 8837912 into develop Jun 30, 2021
@ChristophHi ChristophHi deleted the feature/GH-11461 branch June 30, 2021 06:02
@ChristophHi ChristophHi temporarily deployed to dev June 30, 2021 06:02 Inactive
@github-actions
Copy link
Contributor

Public API changes

✔️ Nothing changed in analyzed entry points.

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/asm/root - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cdc/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cdc/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cds - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/checkout/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/checkout/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product/bulk-pricing/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product/bulk-pricing - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product/variants/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product/variants/root - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/common - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased/cpq - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased/root - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/textfield - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/textfield/root - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/qualtrics/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/user/account/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/profile/components - ERROR: "import * as ___ from ___;" is not supported yet for local files.

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophHi ChristophHi ChristophHi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User should be informed if it's not possible to remove bundle product
2 participants
@Changsuwan @ChristophHi