Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Saved carts: can't delete description when editing #12680

Merged
merged 5 commits into from
Jun 10, 2021

Conversation

bgambocjaviniar
Copy link
Contributor

closes GH-11807

@cypress
Copy link

cypress bot commented Jun 4, 2021



Test summary

2 0 0 0Flakiness 0


Run details

Project spartacus
Status Passed
Commit e6d9acb ℹ️
Started Jun 10, 2021 5:45 PM
Ended Jun 10, 2021 5:46 PM
Duration 01:03 💡
OS Linux Ubuntu - 18.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

hackergil
hackergil previously approved these changes Jun 4, 2021
@bgambocjaviniar bgambocjaviniar dismissed hackergil’s stale review June 4, 2021 20:33

Sorry I sent the wrong PR to approve

@github-actions
Copy link
Contributor

Hosting service deployment

❗ Spartacus deployment failed ( ERR Failed to execute command [application deploy] due to: Error: Deploy
Failed. Could not generate environment or presigned URL.
Response code: 500
Message: Could not deploy new application, the limit: 20 for the
tenant: spartacus has been reached
Type: internal_service_error

). Check job logs for details.)

@bgambocjaviniar bgambocjaviniar merged commit 2695f21 into develop Jun 10, 2021
@bgambocjaviniar bgambocjaviniar deleted the feature/GH-11807 branch June 10, 2021 18:13
@bgambocjaviniar bgambocjaviniar temporarily deployed to dev June 10, 2021 18:13 Inactive
@github-actions
Copy link
Contributor

Public API changes

✔️ Nothing changed in analyzed entry points.

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/account/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/profile/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved carts: can't delete description when editing
3 participants