Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-11818 feature lib for quick order #11856

Merged

Conversation

dydome
Copy link
Contributor

@dydome dydome commented Apr 7, 2021

close #11818

@dydome dydome temporarily deployed to dev April 7, 2021 12:57 Inactive
@dydome dydome temporarily deployed to dev April 8, 2021 05:57 Inactive
@cypress
Copy link

cypress bot commented Apr 8, 2021



Test summary

472 0 9 0Flakiness 1


Run details

Project spartacus
Status Passed
Commit 0d9f914 ℹ️
Started Apr 8, 2021 7:41 AM
Ended Apr 8, 2021 7:50 AM
Duration 08:11 💡
OS Linux Ubuntu - 18.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/regression/cart.e2e-spec.ts Flakiness
1 ... > should add and remove products

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@marlass marlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you added all the tsconfigs by hand or with the yarn config:update script?

feature-libs/cart/schematics/add-cart/index_spec.ts Outdated Show resolved Hide resolved
@dydome dydome temporarily deployed to dev April 8, 2021 06:47 Inactive
@dydome dydome temporarily deployed to dev April 8, 2021 07:31 Inactive
@dydome dydome requested a review from marlass April 8, 2021 07:33
@dydome dydome self-assigned this Apr 8, 2021
@dydome dydome merged commit 9e7f95f into epic/quick-order Apr 8, 2021
@dydome dydome deleted the feature/GH-11818-feature-lib-for-quick-order branch April 8, 2021 07:42
@dydome dydome temporarily deployed to dev April 8, 2021 07:42 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

Public API changes

⚠️ @spartacus/cart/quick-order/assets

New entry point. Initial public api:

import { TranslationChunksConfig } from '@spartacus/core';
import { TranslationResources } from '@spartacus/core';

// @public (undocumented)
export const quickOrderTranslationChunksConfig: TranslationChunksConfig;

// @public (undocumented)
export const quickOrderTranslations: TranslationResources;


// (No @packageDocumentation comment for this package)

⚠️ @spartacus/cart/quick-order/components

New entry point. Initial public api:

// @public (undocumented)
export class QuickOrderComponentsModule {
}

// @public (undocumented)
export class QuickOrderListComponent {
}

// @public (undocumented)
export class QuickOrderListModule {
}


// (No @packageDocumentation comment for this package)

⚠️ @spartacus/cart/quick-order/core

New entry point. Initial public api:

import { ModuleWithProviders } from '@angular/core';
import { Observable } from 'rxjs';
import { OrderEntry } from '@spartacus/core';

// @public (undocumented)
export abstract class QuickOrderAdapter {
    abstract addToCart(userId: string, cartId: string, entries: OrderEntry[]): Observable<void>;
}

// @public (undocumented)
export class QuickOrderConnector {
    constructor(adapter: QuickOrderAdapter);
    // (undocumented)
    protected adapter: QuickOrderAdapter;
    // (undocumented)
    addToCart(userId: string, cartId: string, entries: OrderEntry[]): Observable<void>;
}

// @public (undocumented)
export class QuickOrderCoreModule {
    // (undocumented)
    static forRoot(): ModuleWithProviders<QuickOrderCoreModule>;
}

// @public (undocumented)
export abstract class QuickOrderEvent {
}

// @public (undocumented)
export class QuickOrderEventBuilder {
    constructor();
}

// @public (undocumented)
export class QuickOrderEventsModule {
    constructor(_quickOrderEventBuilder: QuickOrderEventBuilder);
}

// @public (undocumented)
export class QuickOrderService {
    constructor();
}


// (No @packageDocumentation comment for this package)

⚠️ @spartacus/cart/quick-order/occ

New entry point. Initial public api:

import { ConverterService } from '@spartacus/core';
import { HttpClient } from '@angular/common/http';
import { Observable } from 'rxjs';
import { OccEndpointsService } from '@spartacus/core';
import { OrderEntry } from '@spartacus/core';
import { QuickOrderAdapter } from '@spartacus/cart/quick-order/core';

// @public (undocumented)
export class OccQuickOrderAdapter implements QuickOrderAdapter {
    constructor(http: HttpClient, occEndpoints: OccEndpointsService, converter: ConverterService);
    // (undocumented)
    addToCart(userId: string, cartId: string, entries: OrderEntry[]): Observable<any>;
    // (undocumented)
    protected converter: ConverterService;
    // (undocumented)
    protected getQuickOrderEndpoint(userId: string, cartId: string, entries: OrderEntry[]): string;
    // (undocumented)
    protected http: HttpClient;
    // (undocumented)
    protected occEndpoints: OccEndpointsService;
}

// @public (undocumented)
export class QuickOrderOccModule {
}


// (No @packageDocumentation comment for this package)

⚠️ @spartacus/cart/quick-order

New entry point. Initial public api:

// @public (undocumented)
export class QuickOrderModule {
}


// (No @packageDocumentation comment for this package)

⚠️ @spartacus/cart/quick-order/root

New entry point. Initial public api:

// @public (undocumented)
export class QuickOrderRootModule {
}


// (No @packageDocumentation comment for this package)

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cdc - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants