Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong number of items for PLP grid #3075

Closed
mirkosoft opened this issue Jun 11, 2019 · 3 comments · Fixed by #10937
Closed

Wrong number of items for PLP grid #3075

mirkosoft opened this issue Jun 11, 2019 · 3 comments · Fixed by #10937
Assignees
@dydome
Labels
bug Something isn't working listings Search and category listings Minor team/obelix
Milestone
before-5.0

Comments

@mirkosoft
Copy link
Contributor

Grid has 3 items per row so if there are 10 items per page the last row contains just one item. It might be interpreted by user as the last page of results (which is not the case as we are on the first page).

image
@mirkosoft mirkosoft added bug Something isn't working ux labels Jun 11, 2019
@Xymmer
Copy link
Contributor

Xymmer commented Jun 11, 2019 •
edited
Loading

the grid always has 3 columns? if so then let's make it 12, but what happens at different viewports?
anyway, not broken, so moving to future

@Xymmer Xymmer added this to the 1.* Candidate milestone Jun 11, 2019
@Xymmer Xymmer added the P3 label Nov 17, 2019
@Xymmer Xymmer modified the milestones: 2.x, FUTURE Feb 7, 2020
@Xymmer Xymmer added listings Search and category listings and removed ux labels Oct 9, 2020
@dydome dydome self-assigned this Jan 29, 2021
dydome added a commit that referenced this issue Jan 29, 2021
@dydome
GH-3075
3476bf0
dydome added a commit that referenced this issue Jan 29, 2021
@dydome
Merge branch 'develop' into feature/GH-3075
b3a0d14
@dydome dydome mentioned this issue Jan 29, 2021
Closed
dydome added a commit that referenced this issue Jan 29, 2021
@dydome
GH-3075
d4068ef
@dydome dydome mentioned this issue Jan 29, 2021
Merged
@mirkosoft mirkosoft self-assigned this Feb 4, 2021
giancorderoortiz added a commit that referenced this issue May 18, 2021
@giancorderoortiz
Merge branch 'develop' into feature/GH-3075
1541cc8
@giancorderoortiz
Copy link
Contributor

Please fix conflicts in pr(if any), and approve/reject.
Would like to test this fix soon.

dydome added a commit that referenced this issue May 19, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
cc58dda
giancorderoortiz added a commit that referenced this issue May 23, 2021
@giancorderoortiz
Merge branch 'develop' into feature/GH-3075
a20df3a
@bgambocjaviniar bgambocjaviniar self-assigned this May 27, 2021
bgambocjaviniar added a commit that referenced this issue May 27, 2021
@bgambocjaviniar
Merge branch 'develop' into feature/GH-3075
87ddd86
bgambocjaviniar added a commit that referenced this issue May 28, 2021
@bgambocjaviniar
Merge branch 'develop' into feature/GH-3075
428f11b
@giancorderoortiz
Copy link
Contributor

Issue still present in Spartacus 3.0 demo server.
https://spartacus-demo.eastus.cloudapp.azure.com/apparel-uk-spa/en/GBP/search?q=men:relevance:gender:MALE&currentPage=1

dydome added a commit that referenced this issue Jun 14, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
344bdee
dydome added a commit that referenced this issue Jun 14, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
39a0a5c
dydome added a commit that referenced this issue Jun 15, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
1fbdbbd
dydome added a commit that referenced this issue Jun 15, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
a306ff8
dydome added a commit that referenced this issue Jun 16, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
4d05687
dydome added a commit that referenced this issue Jun 16, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
944b18b
dydome added a commit that referenced this issue Jun 16, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
c05dec8
bgambocjaviniar added a commit that referenced this issue Jun 16, 2021
@bgambocjaviniar
Merge branch 'develop' into feature/GH-3075
8574df4
Parthlakhani added a commit that referenced this issue Jun 16, 2021
@Parthlakhani
Merge branch 'develop' into feature/GH-3075
ba73b7a
dydome added a commit that referenced this issue Jun 17, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
e99bf21
dydome added a commit that referenced this issue Jun 17, 2021
@dydome
Merge branch 'feature/GH-3075' of github.com:SAP/spartacus into feature/
5e023b7 
GH-3075
dydome added a commit that referenced this issue Jun 17, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
0febcfc
dydome added a commit that referenced this issue Jun 17, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
22cb5aa
@bgambocjaviniar bgambocjaviniar removed their assignment Jun 17, 2021
dydome added a commit that referenced this issue Jun 18, 2021
@dydome
Merge remote-tracking branch 'origin/develop' into feature/GH-3075
c507f0c
dydome added a commit that referenced this issue Jun 18, 2021
@dydome
Merge branch 'feature/GH-3075' of github.com:SAP/spartacus into feature/
a08368c 
GH-3075
dydome added a commit that referenced this issue Jun 18, 2021
@dydome
Change product list default page size to 12 (#10937)
d9842af 
chore: Change product list default page size to 12 (#3075)
@Xymmer Xymmer removed this from the FUTURE milestone Nov 25, 2021
@Xymmer Xymmer added this to the before-5.0 milestone Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dydome dydome

Labels
bug Something isn't working listings Search and category listings Minor team/obelix
Projects
None yet
Milestone
before-5.0
6 participants
@mirkosoft @Xymmer @dydome @kacperknapik @bgambocjaviniar @giancorderoortiz