Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Promise result of the Angular navigation in RoutingService #12789

Closed
Platonn opened this issue Jun 15, 2021 · 0 comments · Fixed by #12795
Closed

Expose Promise result of the Angular navigation in RoutingService #12789

Platonn opened this issue Jun 15, 2021 · 0 comments · Fixed by #12795
Assignees
@Platonn @dunqan
Labels
breaking-change migration-docs public-api routing

Comments

@Platonn
Copy link
Contributor

Platonn commented Jun 15, 2021 •
edited
Loading

Let's expose the Promise result of the Angular router.naviagte() via our RoutingService.go return value.
So we need to move out the router logic from router ngrx effect directly to the RoutingService.

This is a slight breaking change so will require migration docs. But no additional schematics needed
@Platonn Platonn self-assigned this Jun 15, 2021
This was referenced Jun 15, 2021
Open
Merged
Closed
Platonn added a commit that referenced this issue Jun 17, 2021
@Platonn
Merge branch 'develop' of github.com:SAP/spartacus into feature/GH-12789
59b031e
Platonn added a commit that referenced this issue Jun 17, 2021
@Platonn
Merge branch 'feature/GH-12789' into feature/GH-12621
79ee888
Platonn added a commit that referenced this issue Jun 18, 2021
@Platonn
Merge branch 'develop' into feature/GH-12789
0c2235b
Platonn added a commit that referenced this issue Jun 18, 2021
@Platonn
Merge branch 'feature/GH-12789' into feature/GH-12621
3820feb
Matejk00 added a commit that referenced this issue Jun 22, 2021
@Matejk00
Merge branch 'develop' into feature/GH-12789
7552e0e
Platonn added a commit that referenced this issue Jun 22, 2021
@Platonn
Merge branch 'develop' into feature/GH-12789
3ce64ae
Platonn added a commit that referenced this issue Jun 22, 2021
@Platonn
feat: expose Promise result of the Angular navigation in RoutingServi…
051d195 
…ce (#12795)

Exposed Promise result of the Angular navigation in methods of the `RoutingService`: `go()` and `goByUrl()`.
Now Angular Router is called directly from the `RoutingService`, but not from ngrx effects anymore. Dropped the effects as well as the actions triggering them.

Added migration docs and schematics for the breaking changes.

By the way, added the missing param `NavigationExtras` in `RoutingService.goByUrl`.

BREAKING CHANGES
The following ngrx actions have been removed:
- `RoutingActions.RouteGo` (and `RoutingActions.ROUTER_GO`)
- `RoutingActions.RouteGoByUrlAction` (and `RoutingActions.ROUTER_GO_BY_URL`)
- `RoutingActions.RouteBackAction` (and `RoutingActions.ROUTER_BACK`)
- `RoutingActions.RouteForwardAction` (and `RoutingActions.ROUTER_FORWARD`).
Please use instead the methods of the `RoutingService`, respectively: `go()`, `goByUrl()`, `back()`, `forward()`.

closes #12789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Platonn Platonn

@dunqan dunqan

Labels
breaking-change migration-docs public-api routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose Promise result of the Angular navigation in RoutingService SAP/spartacus
2 participants
@Platonn @dunqan