Skip to content

Commit

Permalink
GH-13807 review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
ChristophHi committed Oct 5, 2021
1 parent 31b4c3a commit 88141d8
Showing 1 changed file with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const sectionHeader = 'header';
const sectionContent = 'content';

describe('CpqConfiguratorPageLayoutHandler', () => {
let serviceUnderTest: CpqConfiguratorPageLayoutHandler;
let classUnderTest: CpqConfiguratorPageLayoutHandler;

beforeEach(
waitForAsync(() => {
Expand All @@ -51,20 +51,20 @@ describe('CpqConfiguratorPageLayoutHandler', () => {
})
);
beforeEach(() => {
serviceUnderTest = TestBed.inject(
classUnderTest = TestBed.inject(
CpqConfiguratorPageLayoutHandler as Type<CpqConfiguratorPageLayoutHandler>
);
});

it('should create service', () => {
expect(serviceUnderTest).toBeDefined();
expect(classUnderTest).toBeDefined();
});

it('should not touch slots for section different than header', () => {
let slots$ = cold('-a', {
a: contentSlots,
});
const handledSlots$ = serviceUnderTest.handle(
const handledSlots$ = classUnderTest.handle(
slots$,
pageTemplateCpq,
sectionContent
Expand All @@ -80,7 +80,7 @@ describe('CpqConfiguratorPageLayoutHandler', () => {
let slots$ = cold('-a-a', {
a: headerSlots,
});
const handledSlots$ = serviceUnderTest.handle(
const handledSlots$ = classUnderTest.handle(
slots$,
pageTemplateCpq,
sectionHeader
Expand All @@ -100,7 +100,7 @@ describe('CpqConfiguratorPageLayoutHandler', () => {
let slots$ = cold('-aaa', {
a: headerSlots,
});
const handledSlots$ = serviceUnderTest.handle(
const handledSlots$ = classUnderTest.handle(
slots$,
pageTemplateCpq,
sectionHeader
Expand All @@ -116,7 +116,7 @@ describe('CpqConfiguratorPageLayoutHandler', () => {
let slots$ = cold('-a-a', {
a: headerSlots,
});
const handledSlots$ = serviceUnderTest.handle(
const handledSlots$ = classUnderTest.handle(
slots$,
pageTemplateOther,
sectionHeader
Expand Down

0 comments on commit 88141d8

Please sign in to comment.