fix: Build issues

- fix building libs and CSR by solvig type errors provided with TS 5.6
SAP · Dec 13, 2024 · 54ca560 · 54ca560
1 parent f95bd2c
commit 54ca560
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/core-libs/setup/ssr/optimized-engine/rendering-cache.ts b/core-libs/setup/ssr/optimized-engine/rendering-cache.ts
@@ -28,7 +28,10 @@ export class RenderingCache {
     if (this.options?.cacheSize) {
       this.renders.delete(key);
       if (this.renders.size >= this.options.cacheSize) {
-        this.renders.delete(this.renders.keys().next().value);
+        const oldestKey = this.renders.keys().next().value;
+        if (oldestKey !== undefined) {
+          this.renders.delete(oldestKey);
+        }
       }
     }
     // cache only if shouldCacheRenderingResult return true

diff --git a/...sections/asm-customer-360-customer-coupon/asm-customer-360-customer-coupon.component.html b/...sections/asm-customer-360-customer-coupon/asm-customer-360-customer-coupon.component.html
@@ -56,7 +56,7 @@
         [type]="iconTypes.CLOSE"
         role="button"
         title="{{ 'common.close' | cxTranslate }}"
-        (click)="this.searchBox.value = ''"
+        (click)="searchBox.value = ''"
       ></cx-icon>
       <cx-icon
         class="cx-asm-customer-360-promotion-listing-search-icon-search"

diff --git a/...ing-reopen/customer-ticketing-reopen-dialog/customer-ticketing-reopen-dialog.component.ts b/...ing-reopen/customer-ticketing-reopen-dialog/customer-ticketing-reopen-dialog.component.ts
@@ -15,9 +15,9 @@ import { Subscription } from 'rxjs';
 import { CustomerTicketingDialogComponent } from '../../../shared/customer-ticketing-dialog/customer-ticketing-dialog.component';
 
 @Component({
-    selector: 'cx-customer-ticketing-reopen-dialog',
-    templateUrl: './customer-ticketing-reopen-dialog.component.html',
-    standalone: false
+  selector: 'cx-customer-ticketing-reopen-dialog',
+  templateUrl: './customer-ticketing-reopen-dialog.component.html',
+  standalone: false,
 })
 export class CustomerTicketingReopenDialogComponent
   extends CustomerTicketingDialogComponent
@@ -34,8 +34,7 @@ export class CustomerTicketingReopenDialogComponent
       this.form.markAllAsTouched();
       FormUtils.deepUpdateValueAndValidity(this.form);
     } else {
-      const mustWaitForAttachment =
-        this.form.get('file')?.value?.length > 0 ?? false;
+      const mustWaitForAttachment = this.form.get('file')?.value?.length > 0;
       this.isDataLoading$.next(true);
       this.subscription = this.customerTicketingFacade
         .createTicketEvent(this.prepareTicketEvent(), mustWaitForAttachment)

diff --git a/projects/schematics/src/add-ssr/index.ts b/projects/schematics/src/add-ssr/index.ts
@@ -66,7 +66,7 @@ declare module '@schematics/angular/utility/workspace-models' {
     /**
      * Since ng17 it's no more "browserTarget" but "buildTarget" property
      */
-    buildTarget?: string;
+    buildTarget: string;
   }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         /**
          * Since ng17 it's no more "browserTarget" but "buildTarget" property
          */
-        buildTarget?: string;
+        buildTarget: string;
       }
     }
@@ Expand Down @@