fix: display error message when resource loading fails (#19622)

CXSPA-8939
SAP · Nov 29, 2024 · 5467c2d · 5467c2d
1 parent b32ecac
commit 5467c2d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/integration-libs/opf/base/root/services/opf-resource-loader.service.spec.ts b/integration-libs/opf/base/root/services/opf-resource-loader.service.spec.ts
@@ -161,7 +161,10 @@ describe('OpfResourceLoaderService', () => {
         }
       );
 
-      opfResourceLoaderService.loadResources([mockScriptResource]);
+      opfResourceLoaderService
+        .loadResources([mockScriptResource])
+        .then(() => {})
+        .catch(() => {});
 
       expect(opfResourceLoaderService['loadStyles']).not.toHaveBeenCalled();
       expect(opfResourceLoaderService['loadScript']).toHaveBeenCalled();
@@ -207,7 +210,10 @@ describe('OpfResourceLoaderService', () => {
         }
       );
 
-      opfResourceLoaderService.loadResources([], [mockStylesResources]);
+      opfResourceLoaderService
+        .loadResources([], [mockStylesResources])
+        .then(() => {})
+        .catch(() => {});
 
       expect(opfResourceLoaderService['loadScript']).not.toHaveBeenCalled();
 

diff --git a/integration-libs/opf/base/root/services/opf-resource-loader.service.ts b/integration-libs/opf/base/root/services/opf-resource-loader.service.ts
@@ -185,8 +185,6 @@ export class OpfResourceLoaderService {
       }
     );
 
-    return Promise.all(resourcesPromises)
-      .then(() => {})
-      .catch(() => {});
+    return Promise.all(resourcesPromises).then(() => {});
   }
 }
diff --git a/.../checkout/components/opf-checkout-payment-wrapper/opf-checkout-payment-wrapper.service.ts b/.../checkout/components/opf-checkout-payment-wrapper/opf-checkout-payment-wrapper.service.ts
@@ -180,6 +180,9 @@ export class OpfCheckoutPaymentWrapperService {
           if (html) {
             this.executeScriptFromHtml(html);
           }
+        })
+        .catch(() => {
+          this.handleGeneralPaymentError().pipe(take(1)).subscribe();
         });
       return;
     }