code change after code review

SAP · Sep 10, 2024 · 35399a3 · 35399a3
1 parent 946c816
commit 35399a3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/projects/core/src/site-theme/facade/site-theme.service.ts b/projects/core/src/site-theme/facade/site-theme.service.ts
@@ -92,10 +92,6 @@ export class SiteThemeService implements SiteContext<SiteTheme> {
       });
   }
 
-  isValid(className: string): boolean {
-    return this.themes.map((theme) => theme.className).includes(className);
-  }
-
   isInitialized(): boolean {
     let valueInitialized = false;
     this.getActive()
@@ -104,4 +100,8 @@ export class SiteThemeService implements SiteContext<SiteTheme> {
 
     return valueInitialized;
   }
+
+  protected isValid(className: string): boolean {
+    return this.themes.map((theme) => theme.className).includes(className);
+  }
 }
diff --git a/projects/storefrontapp-e2e-cypress/cypress/helpers/site-theme.ts b/projects/storefrontapp-e2e-cypress/cypress/helpers/site-theme.ts
@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+// TODO: (CXSPA-8363) This is only a temporary solution until we deploy the proper sample data to the CI server. Once that is done, this code should be removed.
 export function interceptToAddThemeCompnent() {
   const path = `${Cypress.env('OCC_PREFIX')}/${Cypress.env(
     'BASE_SITE'