Merge branch 'develop' into feat/CXSPA-9134

SAP · Dec 20, 2024 · 352dc7c · 352dc7c
2 parents 3809785 + cb8b1fd
commit 352dc7c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/minor-release.yml b/.github/workflows/minor-release.yml
@@ -1,4 +1,4 @@
-name: Minor Release ${{ github.event.inputs.version }}
+name: Minor Release
 
 on:
   workflow_dispatch:

diff --git a/...ute/types/multi-selection-image/configurator-attribute-multi-selection-image.component.ts b/...ute/types/multi-selection-image/configurator-attribute-multi-selection-image.component.ts
@@ -53,6 +53,7 @@ export class ConfiguratorAttributeMultiSelectionImageComponent
     );
 
     useFeatureStyles('productConfiguratorAttributeTypesV2');
+    useFeatureStyles('a11yDifferentiateFocusedAndSelected');
   }
 
   attributeCheckBoxForms = new Array<UntypedFormControl>();

diff --git a/projects/storefrontlib/shared/components/carousel/carousel.component.html b/projects/storefrontlib/shared/components/carousel/carousel.component.html
@@ -96,11 +96,7 @@ <h2 *ngIf="title">{{ title }}</h2>
     </ng-container>
   </div>
 
-  <div
-    *ngIf="!hideIndicators && size < items.length"
-    role="tablist"
-    class="indicators"
-  >
+  <div *ngIf="!hideIndicators && size < items.length" class="indicators">
     <ng-container *ngFor="let _ of items; let i = index">
       <!-- TODO: (CXSPA-6904) - Remove feature flag next major release -->
       <ng-container *cxFeature="'a11yFocusableCarouselControls'">
@@ -125,7 +121,6 @@ <h2 *ngIf="title">{{ title }}</h2>
                     numberOfSlides: size,
                   }
           "
-          role="tab"
         >
           <cx-icon [type]="indicatorIcon" aria-hidden="true"></cx-icon>
         </button>
-Original file line number
+Diff line change
@@ Expand Up @@
         );
         useFeatureStyles('productConfiguratorAttributeTypesV2');
+        useFeatureStyles('a11yDifferentiateFocusedAndSelected');
       }
       attributeCheckBoxForms = new Array<UntypedFormControl>();
@@ Expand Down @@