Hierarchical line items #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like option 1 and 2, with the first one being my preferred (additional property on the PV). But i do see the value of the first one in case people don't want to go through the trouble of defining one. |
|
Option 1 is my favorite, and I find option 3 a little bit cumbersome |
|
I am fine with option 1. |
|
Thanks for judging and voting! I removed variant 2 and 3. Please review - thanks! |
nlunets
previously approved these changes
Jul 11, 2024
HeikoTheissen
previously approved these changes
Jul 11, 2024
ralfhandl
previously approved these changes
Jul 11, 2024
ralfhandl
dismissed stale reviews from HeikoTheissen, nlunets, and themself
via
b28c257
ralfhandl
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is about the possibility to apply a hierarchy (and later one aggregation ) on existing list definition (aka UI.LineItem). We start with three different proposals: adding a new property to UI.PresentationVariant, adding a new term that can be applied on UI.LineItem annotations, adding a new term that uses UI.LineItem as BaseTerm.