-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge cells in table columns #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You annotate a UI.LineItem
with a collection of Edm.PropertyPath
s. But the line item contains
<Record Type="UI.DataField">
<PropertyValue Property="Value" Path="..." />
</Record>
and can even combine more than one property.
I suggest to annotate the UI.DataField
record instead with a Boolean term:
<Record Type="UI.DataField">
<Annotation Term="HTML5.PreferRowSpan" Bool="true" />
<PropertyValue Property="Value" Path="..." />
</Record>
That sounds indeed interesting - thank you @HeikoTheissen ! The only thing that I'm not 100% convinced of is the name (esp. the "Prefer"). I will prepare a new commit. |
define the required type for the annotation Co-authored-by: Heiko Theißen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add reference to UI vocabulary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new term name and where it applies!
Create an opportunity to define columns in a table where the cells are merged if the adjacent values are the same (in html rowSpan would be used). I decided to go as a starting point with an HTML5 collection of propertyPath that can be applied to UI.LineItem. Imo this new annotation makes only sense for UI.LineItem, and I didn't want to change the term itself.
Other possibilities would be applying the annotation to properties or adding something to the UI.PresentationVariant.