Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI-based recommendations with draft #302

Merged
merged 103 commits into from
Jul 11, 2024
Merged

Conversation

HeikoTheissen
Copy link
Contributor

@HeikoTheissen HeikoTheissen commented Jan 11, 2024

Unlike #276, in this variant the server stores the recommendations in the (collaborative) draft and updates them

  • only if their input has changed (advantage, especially with collaborative draft)
  • but independent of the $select clause of the client(s).

This means that recommendations are computed for all items, even if the client(s) display only the first 5 items and want recommendations only for these.

vocabularies/UI.xml Outdated Show resolved Hide resolved
ralfhandl
ralfhandl previously approved these changes Jan 24, 2024
vocabularies/UI.xml Outdated Show resolved Hide resolved
MarcelWaechter
MarcelWaechter previously approved these changes Jul 1, 2024
Copy link
Contributor

@MarcelWaechter MarcelWaechter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm fine with it. Let's see if Saurabh has any doubts

vocabularies/UI.xml Outdated Show resolved Hide resolved
vocabularies/UI.xml Outdated Show resolved Hide resolved
vocabularies/UI.xml Outdated Show resolved Hide resolved
vocabularies/UI.xml Show resolved Hide resolved
vocabularies/UI.xml Show resolved Hide resolved
vocabularies/UI.xml Outdated Show resolved Hide resolved
vocabularies/UI.xml Outdated Show resolved Hide resolved
Copy link
Member

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only two minor things:

  • If recommendations are computed asynchronously, how long should the client wait before reading them?
  • Would be nice to have a response example in recommendations.md

@HeikoTheissen HeikoTheissen merged commit c94544c into main Jul 11, 2024
3 checks passed
@HeikoTheissen HeikoTheissen deleted the Common.Recommendations2 branch July 11, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants