fix(cloudFoundryDeploy): handle large amount of mta extension credentials #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@niki4 Can you add a description on the PR, just to understand better |
added 2 commits
December 18, 2024 14:37
|
|
/it-go |
|
This PoC seems not fixes user issue, so I'm going to abandon it. We found the root cause and it has been fixed in another PR: #5216 |
niki4
deleted the
ivan/fix-cloudFoundryDeploy-mtaExtensionCredentials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PoC PR that about to bypass limitation on large amount of mta extension credentials set in .pipeline/config.yaml for cloudFoundryDeploy step.
We introduce step parameter "checkMissingCredentials". If this option is set to false, then Piper will not check for missing mta extension credentials in env vars. Use this option if you have large amount of mtaExtensionCredentials values.
References
INC10351618 | Blocked service deployment due to failing cloudFoundryDeploy
Checklist