Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Overwriting of parameters from Vault #5195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(docs): Overwriting of parameters from Vault #5195

wants to merge 1 commit into from

Conversation

mzuber
Copy link
Contributor

@mzuber mzuber commented Dec 2, 2024

The current documentation section for overwriting parameters from Vault states:

To disable overriding parameters put a vaultDisableOverwrite: false on Step Stage or General Section in
Vault.

This isn't correct, setting vaultDisableOverwrite: true actually disables overriding parameters (also see behavior in the corresponding test).

@mzuber mzuber requested a review from a team as a code owner December 2, 2024 08:14
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mzuber mzuber changed the title Fix documentation for overwriting of parameters from Vault fix(docs): Overwriting of parameters from Vault Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mzuber