Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for buildTool and buildDescriptorFile #5193

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Added validation for buildTool and buildDescriptorFile #5193

merged 5 commits into from
Dec 12, 2024
+117 −0

Conversation

akram8008
Copy link
Contributor

Added validation for buildTool and buildDescriptorFile on whitesourceExecuteScan step

@akram8008 akram8008 requested a review from a team as a code owner November 29, 2024 15:45
@dimaste
Copy link
Member

dimaste commented Dec 2, 2024

/it-go

@dimaste
Copy link
Member

dimaste commented Dec 4, 2024

/it-go

dimaste
dimaste reviewed Dec 4, 2024
View reviewed changes
cmd/whitesourceExecuteScan.go Outdated Show resolved Hide resolved
cmd/whitesourceExecuteScan.go Show resolved Hide resolved
@dimaste
Copy link
Member

dimaste commented Dec 4, 2024

/it-go

@dimaste
Copy link
Member

dimaste commented Dec 5, 2024

/it-go

@dimaste
Copy link
Member

dimaste commented Dec 5, 2024

/it-go

@dimaste
Copy link
Member

dimaste commented Dec 12, 2024

/it-go

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dimaste dimaste merged commit e927605 into SAP:master Dec 12, 2024
13 checks passed
@niki4
Copy link
Member

niki4 commented Dec 16, 2024

Hello, one of Piper users pointed to this change in #sap-piper-users channel:

Hello colleagues. The new validation in whitesourceExecuteScan broke our pipelines.
Background, we do have an mta GitHub repo with two Node.js components and we scan both components in parallel in separate Jenkins steps (mainly to visualize it for the developers). This fails with Error: failed to resolve project identifiers: failed to get build artifact description: extension of buildDescriptorFile must be in '*.yaml'. The buildTools is mta but the execution of whitesourceExecuteScan is triggered with e.g. buildDescriptorFile: 'approuter/package.json'.
Can this change be explained to see the benefit of it? It was working fine before.

maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jan 10, 2025
@maxatsap
Merge remote-tracking branch 'origin/master' into kaniko-context-pref…
79ddd80 
…ix-fix

* origin/master: (36 commits)
  Revert changes done to release action (SAP#5228)
  Update release-go.yml (SAP#5227)
  Remove README and CONTRIBUTING files from release 3rd try (SAP#5226)
  fix(setupCommonPipelineEnvironment): handling tags from scm info (SAP#5219)
  Remove README and CONTRIBUTING files from release 2nd try (SAP#5225)
  [CxONE] Improve report: add Low findings; Proposed Not Exploitable state (SAP#5223)
  Remove README and CONTRIBUTING files from release (SAP#5221)
  fix(naming): Rename Trust Engine to System Trust (SAP#5217)
  abapEnvironmentAssemblePackages Check for Build Errors (SAP#5214)
  docs: fix npmExuceteTests documentation formatting issues (SAP#5218)
  feat: Introduce new npmExecuteTests step (SAP#5124)
  fix(cloudFoundryDeploy): argument list too long (SAP#5216)
  Revert "Fix deployment failure with CF if password contains special char (SAP#5197)" (SAP#5215)
  chore(trustengine): Rename Trust Engine to System Trust in logs and docs (SAP#5210)
  Fix deployment failure with CF if password contains special char (SAP#5197)
  Update go version to 1.23 and removed some helper methods in favor of STD library (SAP#5200)
  Added validation for buildTool and buildDescriptorFile (SAP#5193)
  Unstash class files for Compliance stage (SAP#5192) (SAP#5204)
  fix(documentation): check param for jenkinsParams before appending Jenkins-specific text (SAP#5203)
  Align description of ADO and GHA (SAP#5202)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jan 10, 2025
@maxatsap
Merge remote-tracking branch 'origin/master' into malwarescan-async-scan
f3b8d51 
* origin/master: (36 commits)
  Revert changes done to release action (SAP#5228)
  Update release-go.yml (SAP#5227)
  Remove README and CONTRIBUTING files from release 3rd try (SAP#5226)
  fix(setupCommonPipelineEnvironment): handling tags from scm info (SAP#5219)
  Remove README and CONTRIBUTING files from release 2nd try (SAP#5225)
  [CxONE] Improve report: add Low findings; Proposed Not Exploitable state (SAP#5223)
  Remove README and CONTRIBUTING files from release (SAP#5221)
  fix(naming): Rename Trust Engine to System Trust (SAP#5217)
  abapEnvironmentAssemblePackages Check for Build Errors (SAP#5214)
  docs: fix npmExuceteTests documentation formatting issues (SAP#5218)
  feat: Introduce new npmExecuteTests step (SAP#5124)
  fix(cloudFoundryDeploy): argument list too long (SAP#5216)
  Revert "Fix deployment failure with CF if password contains special char (SAP#5197)" (SAP#5215)
  chore(trustengine): Rename Trust Engine to System Trust in logs and docs (SAP#5210)
  Fix deployment failure with CF if password contains special char (SAP#5197)
  Update go version to 1.23 and removed some helper methods in favor of STD library (SAP#5200)
  Added validation for buildTool and buildDescriptorFile (SAP#5193)
  Unstash class files for Compliance stage (SAP#5192) (SAP#5204)
  fix(documentation): check param for jenkinsParams before appending Jenkins-specific text (SAP#5203)
  Align description of ADO and GHA (SAP#5202)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jan 10, 2025
@maxatsap
Merge remote-tracking branch 'origin/master' into whitesource-sbt-con…
9fabb76 
…fig-fix

* origin/master: (36 commits)
  Revert changes done to release action (SAP#5228)
  Update release-go.yml (SAP#5227)
  Remove README and CONTRIBUTING files from release 3rd try (SAP#5226)
  fix(setupCommonPipelineEnvironment): handling tags from scm info (SAP#5219)
  Remove README and CONTRIBUTING files from release 2nd try (SAP#5225)
  [CxONE] Improve report: add Low findings; Proposed Not Exploitable state (SAP#5223)
  Remove README and CONTRIBUTING files from release (SAP#5221)
  fix(naming): Rename Trust Engine to System Trust (SAP#5217)
  abapEnvironmentAssemblePackages Check for Build Errors (SAP#5214)
  docs: fix npmExuceteTests documentation formatting issues (SAP#5218)
  feat: Introduce new npmExecuteTests step (SAP#5124)
  fix(cloudFoundryDeploy): argument list too long (SAP#5216)
  Revert "Fix deployment failure with CF if password contains special char (SAP#5197)" (SAP#5215)
  chore(trustengine): Rename Trust Engine to System Trust in logs and docs (SAP#5210)
  Fix deployment failure with CF if password contains special char (SAP#5197)
  Update go version to 1.23 and removed some helper methods in favor of STD library (SAP#5200)
  Added validation for buildTool and buildDescriptorFile (SAP#5193)
  Unstash class files for Compliance stage (SAP#5192) (SAP#5204)
  fix(documentation): check param for jenkinsParams before appending Jenkins-specific text (SAP#5203)
  Align description of ADO and GHA (SAP#5202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaste dimaste dimaste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akram8008 @dimaste @niki4