Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused script from test #5047

Closed
wants to merge 1 commit into from
Closed

Conversation

o-liver
Copy link
Member

@o-liver o-liver commented Sep 16, 2024

These scripts don't exist.

Changes

  • Tests
  • Documentation

These scripts are never used.
@o-liver o-liver self-assigned this Sep 16, 2024
@o-liver o-liver requested a review from a team as a code owner September 16, 2024 10:28
Copy link

@o-liver
Copy link
Member Author

o-liver commented Sep 16, 2024

/it

@srinikitha09
Copy link
Contributor

Maybe we can close the PR as this change is already part of this PR #5029 .

@o-liver
Copy link
Member Author

o-liver commented Sep 16, 2024

already done with #5029

@o-liver o-liver closed this Sep 16, 2024
@o-liver
Copy link
Member Author

o-liver commented Sep 16, 2024

Maybe we can close the PR as this change is already part of this PR #5029 .

I wanted to see the ITs and they were green. I cannot explain why you had to change the log file names in your PR for it to work. I'm a little bit worried.

@srinikitha09
Copy link
Contributor

Maybe we can close the PR as this change is already part of this PR #5029 .

I wanted to see the ITs and they were green. I cannot explain why you had to change the log file names in your PR for it to work. I'm a little bit worried.

As far as I understood, renaming files would not affect anything but just addition of 3 more files in workspace during tests execution.. If you still think it would be an issue, I can open a new PR with old file name. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants