feat(build): add buildSettingsInfo for gradleExecuteBuild #5043
Conversation
|
/it-go |
|
this needs to be changed, should be |
|
and just a comment, up to you if you want to change It as well: |
CCFenner
changed the title
Co-authored-by: Tilo Körner <[email protected]>
| } | ||
| buildSettingsInfo, err := buildsettings.CreateBuildSettingsInfo(&gradleConfig, stepNameForBuildSettings) | ||
| if err != nil { | ||
| log.Entry().Warnf("failed to create build settings info: %v", err) |
There was a problem hiding this comment.
Why do we fail above, but not here?
There was a problem hiding this comment.
the buildSettings info gathering can fail, but that must fail the step, its a compliance information fetch fail, but i am not sure if the entire step should fail for that reason ?
There was a problem hiding this comment.
It works the same way across all build steps.
If we have a warning instead of err, in case the method above fails, dockerImage in build-settings will be an empty string, but in fact gradle image is used.
It is compliance information, not sure if having wrong docker image info is ok.
|
/it-go |
1 similar comment
|
/it-go |
vstarostin
force-pushed
the
anil/gradleBuildSettings
branch
from
6941063 to
63df010
Compare
|
|
/it-go |
Changes
build settings metadata extension for the gradle build step