Fix integration tests #4964
Merged
Fix integration tests #4964
+165
−464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/it-go |
|
vstarostin
commented
Jun 19, 2024
Comment on lines
+31
to
+33
| Mounts: testcontainers.Mounts( | ||
| testcontainers.BindMount(dir, "/data"), | ||
| ), |
There was a problem hiding this comment.
modification needed due to changes introduced in the new version of the testcontainers
vstarostin
commented
Jun 19, 2024
| //ToDo: we may set up a tmp directory and mount it in addition, e.g. for runtime artifacts ... | ||
| } | ||
|
|
||
| testContainer, err := testcontainers.GenericContainer(ctx, testcontainers.GenericContainerRequest{ | ||
| ContainerRequest: req, | ||
| Started: true, | ||
| }) | ||
| assert.NoError(t, err) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
if fails to run a container, doesn't make sense to continue test
Googlom
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
Closed
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* Commit * Fix integration tests * Fix integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
integration tests fail: https://github.com/SAP/jenkins-library/actions/runs/9570076133
reason is testcontainers-go package. Piper uses very old version of the package.
This pull request upgrades the library version and as a result, changes to the codebase are required to accommodate the modifications introduced in the new version of the library.