Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sed cmd to transform querySuite #4945

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

daskuznetsova
Copy link
Contributor

Changes

Added new param 'transformString' that will be applied to the querySuite using the sed command.

  • Tests
  • Documentation

@daskuznetsova daskuznetsova requested a review from a team as a code owner June 3, 2024 11:14
@daskuznetsova daskuznetsova marked this pull request as draft June 3, 2024 13:11
@daskuznetsova daskuznetsova removed request for a team, sumeetpatil and vlkl-sap June 3, 2024 13:11
@daskuznetsova daskuznetsova marked this pull request as ready for review June 5, 2024 11:53
@@ -240,6 +240,13 @@ spec:
- STEPS
- STAGES
- PARAMETERS
- name: transformString
Copy link
Contributor

@sumeetpatil sumeetpatil Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to transformQuerySuite

Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sumeetpatil
Copy link
Contributor

/it-go

@daskuznetsova daskuznetsova merged commit 67ed27f into SAP:master Jun 6, 2024
12 checks passed
@daskuznetsova daskuznetsova deleted the codeql-transform-cmd branch June 6, 2024 12:14
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* added sed cmd to transform querySuite

* changed sh to bash

* added checking os

* fixed tests by mocking utils

* fixed tests

* renamed param

---------

Co-authored-by: sumeet patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants