Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and validate the GCP OIDC token #4899

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Generate and validate the GCP OIDC token #4899

merged 9 commits into from
Apr 18, 2024

Conversation

jliempt
Copy link
Member

@jliempt jliempt commented Apr 18, 2024

Changes

  • Created functionalities to get GCP OIDC token from vault and to validate the generated token
  • Tests
  • Documentation

@jliempt jliempt requested a review from a team as a code owner April 18, 2024 11:37
@jliempt jliempt changed the base branch from master to events April 18, 2024 11:44
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jliempt jliempt merged commit 2d74210 into events Apr 18, 2024
3 checks passed
@jliempt jliempt deleted the sachin/hyperthon branch April 18, 2024 11:46
jliempt added a commit that referenced this pull request May 6, 2024
* feat(gcp): add step to send events to GCP (#4896)

* add gcp token handling

* add initial step

* publish events

* add test cases

* fix test case

---------

Co-authored-by: Jordi van Liempt <[email protected]>

* feat(gcp): Generate and validate the GCP OIDC token (#4899)

* test setup for generation of jwt token

* oidc token generator

* push new step files

* formatted code

* removed toolchain and jose

* removed toolchain:go 1.22.2

---------

Co-authored-by: jliempt <>
Co-authored-by: D071696 <[email protected]>
Co-authored-by: d071696 <[email protected]>

* feat(events): add pipeline start and end event (#4900)

* add gcp token handling

* add initial step

* publish events

* add test cases

* fix test case

* move files

* add possible values

* handle start and end event

* add sap events

* dependencies

---------

Co-authored-by: Jordi van Liempt <[email protected]>

* log successful event publish

* remove dummy step

* prevent step from failing

* improve event creation

* improve event creation

* simplify eventing

* remove detailed events

* update parameter scope

* update go.sum

* fix test case

* add missing method

* refactor OIDC part

* add oidc.go to vault pkg

* mock OIDC token retrieval

* mock GCP functions

* update OIDC function name in Vault mocks

* get event data from CPE

* don't encode data payload in b64

* remove vault related changes

* remove vault changes from step code

* remove commented out code

* documentation/steps/gcpPublishEvent.md

* documentation/steps/gcpPublishEvent.md

* remove hardcoded eventData

* update roleID

* go generate

* add ordering key for pubsub event

---------

Co-authored-by: Jordi van Liempt <[email protected]>
Co-authored-by: D071696 <[email protected]>
Co-authored-by: d071696 <[email protected]>
Co-authored-by: jliempt <>
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* feat(gcp): add step to send events to GCP (SAP#4896)

* add gcp token handling

* add initial step

* publish events

* add test cases

* fix test case

---------

Co-authored-by: Jordi van Liempt <[email protected]>

* feat(gcp): Generate and validate the GCP OIDC token (SAP#4899)

* test setup for generation of jwt token

* oidc token generator

* push new step files

* formatted code

* removed toolchain and jose

* removed toolchain:go 1.22.2

---------

Co-authored-by: jliempt <>
Co-authored-by: D071696 <[email protected]>
Co-authored-by: d071696 <[email protected]>

* feat(events): add pipeline start and end event (SAP#4900)

* add gcp token handling

* add initial step

* publish events

* add test cases

* fix test case

* move files

* add possible values

* handle start and end event

* add sap events

* dependencies

---------

Co-authored-by: Jordi van Liempt <[email protected]>

* log successful event publish

* remove dummy step

* prevent step from failing

* improve event creation

* improve event creation

* simplify eventing

* remove detailed events

* update parameter scope

* update go.sum

* fix test case

* add missing method

* refactor OIDC part

* add oidc.go to vault pkg

* mock OIDC token retrieval

* mock GCP functions

* update OIDC function name in Vault mocks

* get event data from CPE

* don't encode data payload in b64

* remove vault related changes

* remove vault changes from step code

* remove commented out code

* documentation/steps/gcpPublishEvent.md

* documentation/steps/gcpPublishEvent.md

* remove hardcoded eventData

* update roleID

* go generate

* add ordering key for pubsub event

---------

Co-authored-by: Jordi van Liempt <[email protected]>
Co-authored-by: D071696 <[email protected]>
Co-authored-by: d071696 <[email protected]>
Co-authored-by: jliempt <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants