-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cnbBuild): validate docker credentials #4840
Conversation
/it-go |
a6b06e0
to
0c55675
Compare
/it-go |
ff91704
to
7fd2eb2
Compare
/it-go |
7fd2eb2
to
9e7bde6
Compare
/it-go |
9e7bde6
to
5bb497a
Compare
/it-go |
5bb497a
to
bd9afcc
Compare
/it-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we maybe make ParseDockerConfig
and GenerateCnbAuth
private and just introduce a cnbutils.GenerateCnbAuthValidFor(config, target)
as public to move all this to auth.go
? So 'cnbBuild.go' just calls a diffferent method?
WDYT?
bd9afcc
to
00d7a99
Compare
/it-go |
00d7a99
to
d0fc485
Compare
d0fc485
to
dd6033e
Compare
/it-go |
Quality Gate passedIssues Measures |
Apparently this pr caused some regression. This reverts commit df2e976.
Changes
This change validates that credentials for the target registry (excluding localhost) can be found in the provided secret. If it is not present, it fails the run and exits with a hopefully more descriptive error on what went wrong.