Clean-up checkIfStepActive #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/it-go |
vstarostin
commented
Feb 2, 2024
vstarostin
commented
Feb 2, 2024
Comment on lines
-84
to
-86
| log.Entry().Warning("This step is using deprecated format of stage conditions which will be removed in Jan 2024. " + | ||
| "To avoid pipeline breakage, please call getDefaults command with --useV1 flag.", | ||
| ) |
There was a problem hiding this comment.
getDefaults step is used by piper-azure-task for downloading piper-defaults (old format) and stage-config (new format). No need to keep the warning message here since we are not going to move piper-defaults to new format
CCFenner
reviewed
Feb 2, 2024
| runSteps = runConfigV1.RunSteps | ||
| runStages = runConfigV1.RunStages | ||
| } else { | ||
| log.Entry().Warning("This step is using deprecated format of stage conditions which will be removed in Jan 2024. " + |
|
/it-go |
CCFenner
approved these changes
Feb 6, 2024
|
/it-go |
|
/it-go |
|
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* Clean-up checkIfStepActive * Mark --useV1 deprecated * Clean up tests * Update test * Add warning message * Update warning msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now stage-config contains only new format (CRD-style). This PR removes old code which was used for old format of stage-config.
- [ ] Documentation