fix(gitopsUpdateDeployment): take into account branch name when clonning #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilkeshav27
reviewed
Feb 1, 2024
|
/it-go |
|
|
/it-go |
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
…ing (SAP#4811) * use branch when clonning a repo * fix unit test mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitopsUpdateDeployment doesn't take into account branchName parameter when clonning a repo. This leads to a bug when specifying branchName other than default (main or master). In that case git clones default branch and then tries to check out to branchName (which doesn't exist in cloned repo) and then creates that branchName from default branch.
This PR fixes this bug by passing branchName into clone function