Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codeqlExecuteScan): Fix for GlobalSettingsFile url checks #4708

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix(codeqlExecuteScan): Fix for GlobalSettingsFile url checks #4708

merged 1 commit into from
Dec 5, 2023

Conversation

sumeetpatil
Copy link
Contributor

Changes

Minor if else fix

  • Tests
  • Documentation

@sumeetpatil sumeetpatil requested a review from a team as a code owner December 5, 2023 05:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrew-kireev andrew-kireev self-requested a review December 5, 2023 08:05
@sumeetpatil
Copy link
Contributor Author

/it

@sumeetpatil sumeetpatil merged commit a6dccf9 into master Dec 5, 2023
13 of 14 checks passed
@sumeetpatil sumeetpatil deleted the fix-codeql-url-check branch December 5, 2023 08:13
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@sumeetpatil @maxatsap
fix(codeqlExecuteScan): Fix for GlobalSettingsFile url checks (SAP#4708)
4d539ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-kireev andrew-kireev andrew-kireev approved these changes

@daskuznetsova daskuznetsova Awaiting requested review from daskuznetsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumeetpatil @andrew-kireev