Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(configs): handle mismatched config types #4700

Merged
merged 6 commits into from
Jan 10, 2024
Merged

feat(configs): handle mismatched config types #4700

merged 6 commits into from
Jan 10, 2024

Conversation

Jk1484
Copy link
Contributor

@Jk1484 Jk1484 commented Nov 29, 2023 •
edited
Loading

Changes

  1. Throw warning if provided config doesn't match metadata type
  • Tests
  • Documentation

@Jk1484 Jk1484 requested a review from a team as a code owner November 29, 2023 09:59
D074360
D074360 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@D074360 D074360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jk1484
Copy link
Contributor Author

Jk1484 commented Jan 9, 2024

/it-go

@Jk1484
Copy link
Contributor Author

Jk1484 commented Jan 10, 2024

/it-go

@Jk1484 Jk1484 enabled auto-merge (squash) January 10, 2024 09:54
@Jk1484 Jk1484 disabled auto-merge January 10, 2024 09:54
@Jk1484
Copy link
Contributor Author

Jk1484 commented Jan 10, 2024

/it-go

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Jk1484 Jk1484 merged commit 5b68fc6 into master Jan 10, 2024
12 checks passed
@Jk1484 Jk1484 deleted the muhammadali.PPMSID branch January 10, 2024 10:02
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@Jk1484 @maxatsap
throw a warning if value of a config is of the wrong type (SAP#4700)
62f39f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D074360 D074360 D074360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jk1484 @D074360