Fix sidecar conditionals #4672
Merged
Fix sidecar conditionals #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anilkeshav27 As discussed, this is a prerequisite to make detectExecuteScan scan images as well. |
2 tasks
c0d1ngm0nk3y
force-pushed
the
fix-sidecar-conditionals
branch
from
1a0c824 to
dcd338a
Compare
|
/it-go |
pbusko
force-pushed
the
fix-sidecar-conditionals
branch
from
d1c391b to
285d431
Compare
|
/it-go |
|
@anilkeshav27 Anything missing? |
pbusko
force-pushed
the
fix-sidecar-conditionals
branch
from
285d431 to
948a709
Compare
|
/it-go |
pbusko
force-pushed
the
fix-sidecar-conditionals
branch
from
948a709 to
6ba2421
Compare
|
/it-go |
|
@anilkeshav27 could you please review the PR? |
pbusko
force-pushed
the
fix-sidecar-conditionals
branch
from
6ba2421 to
3eddad8
Compare
|
/it-go |
pbusko
force-pushed
the
fix-sidecar-conditionals
branch
from
3eddad8 to
28a7077
Compare
|
/it-go |
Co-authored-by: Philipp Stehle <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Philipp Stehle <[email protected]>
modulo11
force-pushed
the
fix-sidecar-conditionals
branch
from
28a7077 to
8254d2b
Compare
|
|
/it-go |
jliempt
added a commit
that referenced
this pull request
Dec 18, 2023
m1ron0xFF
pushed a commit
that referenced
this pull request
Jan 18, 2024
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* fix sidecar conditionals Co-authored-by: Philipp Stehle <[email protected]> * Fix unit tests Co-authored-by: Ralf Pannemans <[email protected]> * Consider parameter used in conditions of sidecars Co-authored-by: Philipp Stehle <[email protected]> --------- Co-authored-by: Johannes Dillmann <[email protected]> Co-authored-by: Philipp Stehle <[email protected]>
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condition did not work for sidecars because the were only evaluated, but never actually added to the config.
Changes