Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npmExecuteScripts): added option to skip installing dev. deps. #4660

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

Jk1484
Copy link
Contributor

@Jk1484 Jk1484 commented Nov 8, 2023

Changes

Added option to skip installing dev. dependencies by providing production parameter of type boolean, skipped if true.

  • Tests
  • Documentation

@Jk1484 Jk1484 requested a review from a team as a code owner November 8, 2023 07:08
@Jk1484
Copy link
Contributor Author

Jk1484 commented Nov 8, 2023

/it-go

Copy link
Member

@anilkeshav27 anilkeshav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we also add a unit test for this case please ?

@Jk1484 Jk1484 force-pushed the muhammadali.npmExecuteScripts branch 2 times, most recently from 01663f9 to a5ad01c Compare November 9, 2023 17:06
@Jk1484 Jk1484 force-pushed the muhammadali.npmExecuteScripts branch from a5ad01c to 23d8971 Compare November 9, 2023 22:26
@Jk1484
Copy link
Contributor Author

Jk1484 commented Nov 9, 2023

/it-go

Copy link
Member

@anilkeshav27 anilkeshav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@anilkeshav27
Copy link
Member

/it-go

@anilkeshav27 anilkeshav27 merged commit f2b236c into master Nov 10, 2023
11 checks passed
@anilkeshav27 anilkeshav27 deleted the muhammadali.npmExecuteScripts branch November 10, 2023 10:04
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
…AP#4660)

* feat(npmExecuteScripts): added option to skip installing dev. deps.

* added unit tests

* setting of OpenFile function for local testing

---------

Co-authored-by: Anil Keshav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants