Fail on error also in case of no lint config present #4658
Conversation
|
/it |
|
/it |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Can we have some unit tests for this? |
I will see what I can do, yes |
|
/it |
|
|
Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add |
Done. |
|
|
||
| t.Run("Test npx eslint fail", func(t *testing.T) { | ||
| lintUtils := newLintMockUtilsBundle() | ||
| lintUtils.execRunner = &mock.ExecMockRunner{ShouldFailOnCommand: map[string]error{"npx --no-install eslint . --ext .js,.jsx,.ts,.tsx -c .pipeline/.eslintrc.json -f checkstyle --ignore-pattern .eslintrc.js -o ./defaultlint.xml": errors.New("exit 1")}} |
There was a problem hiding this comment.
[MINOR] Probably we can break this line into 2.
|
/it |
|
* Fail on error also in case of no lint config present * Fix errors * test: add unit test
Changes