Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

artifactPrepareVersion: support conditions for customTLSCertificateLinks parameter #4631

Merged
merged 4 commits into from
Oct 16, 2023
Merged

artifactPrepareVersion: support conditions for customTLSCertificateLinks parameter #4631

merged 4 commits into from
Oct 16, 2023

Conversation

vstarostin
Copy link
Member

@vstarostin vstarostin commented Oct 13, 2023 •
edited
Loading

Changes

This PR adds the possibility to provide conditions for the customTLSCertificateLinks.
It is useful when parameter values are provided via piper-defaults.

steps:
   artifactPrepareVersion:
      maven:
         customTlsCertificateLinks: [link] 
      gradle:
         customTlsCertificateLinks: [link]

So in this case customTlsCertificateLinks is applied only for gradle and maven projects.

  • Tests
  • Documentation

@vstarostin vstarostin marked this pull request as ready for review October 13, 2023 13:57
@vstarostin vstarostin requested a review from a team as a code owner October 13, 2023 13:57
@vstarostin
Copy link
Member Author

/it-go

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vstarostin
Copy link
Member Author

/it-go

@vstarostin vstarostin merged commit 3761a9f into master Oct 16, 2023
11 checks passed
@vstarostin vstarostin deleted the vstarostin/update-custom-tls-certificate-links-param branch October 16, 2023 11:57
andrew-kireev pushed a commit that referenced this pull request Oct 17, 2023
@vstarostin @andrew-kireev
artifactPrepareVersion: support conditions for customTLSCertificateLi…
c069796 
…nks parameter (#4631)

* Add conditions for customTlsCertificateLinks

* go generate
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@vstarostin @maxatsap
artifactPrepareVersion: support conditions for customTLSCertificateLi…
2dc9c90 
…nks parameter (SAP#4631)

* Add conditions for customTlsCertificateLinks

* go generate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CCFenner CCFenner CCFenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstarostin @CCFenner