Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vault): structure vault logs #4627

Merged
merged 2 commits into from
Oct 11, 2023
Merged

chore(vault): structure vault logs #4627

merged 2 commits into from
Oct 11, 2023

Conversation

CCFenner
Copy link
Member

@CCFenner CCFenner commented Oct 11, 2023 •
edited
Loading

This PR gives some structure to the vault log output which previously looked like this:

Bildschirmfoto 2023-10-11 um 08 44 23

Now it will look like this:
Bildschirmfoto 2023-10-11 um 09 23 28

@CCFenner CCFenner requested a review from a team as a code owner October 11, 2023 07:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CCFenner CCFenner requested a review from anilkeshav27 October 11, 2023 07:36
@CCFenner CCFenner changed the title feat(vault): structure vault logs chore(vault): structure vault logs Oct 11, 2023
anilkeshav27
anilkeshav27 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@anilkeshav27 anilkeshav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CCFenner CCFenner merged commit 20e1fb5 into master Oct 11, 2023
@CCFenner CCFenner deleted the CCFenner-patch-9 branch October 11, 2023 08:14
daskuznetsova pushed a commit to daskuznetsova/jenkins-library that referenced this pull request Oct 13, 2023
@CCFenner @daskuznetsova
chore(vault): structure vault logs (SAP#4627)
b8a827e 
* structure vault logs

* Update client.go
andrew-kireev pushed a commit that referenced this pull request Oct 17, 2023
@CCFenner @andrew-kireev
chore(vault): structure vault logs (#4627)
f43193a 
* structure vault logs

* Update client.go
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@CCFenner @maxatsap
chore(vault): structure vault logs (SAP#4627)
d17260e 
* structure vault logs

* Update client.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilkeshav27 anilkeshav27 anilkeshav27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CCFenner @anilkeshav27