Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Vault): retry Vault request (EOF) errors #4620

Merged
merged 5 commits into from
Oct 19, 2023
Merged

fix(Vault): retry Vault request (EOF) errors #4620

merged 5 commits into from
Oct 19, 2023

Conversation

jliempt
Copy link
Member

@jliempt jliempt commented Oct 9, 2023

Changes

  • Tests
  • Documentation

@anilkeshav27 anilkeshav27 marked this pull request as ready for review October 19, 2023 09:49
@anilkeshav27 anilkeshav27 requested a review from a team as a code owner October 19, 2023 09:49
anilkeshav27
anilkeshav27 reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@anilkeshav27 anilkeshav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anilkeshav27
Copy link
Member

/it-go

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@anilkeshav27
Copy link
Member

/it-go

@anilkeshav27 anilkeshav27 merged commit d05b53c into master Oct 19, 2023
11 checks passed
@anilkeshav27 anilkeshav27 deleted the jliempt/testVaultRetries branch October 19, 2023 12:34
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@jliempt @Jk1484 @maxatsap
fix(Vault): retry Vault request (EOF) errors (SAP#4620)
a7d9c8b 
* retry Vault request errors and add extensive logging

* fix sigsegv and change logging

* refining logs

* changing debug to info

---------

Co-authored-by: jliempt <>
Co-authored-by: Muhammadali Nazarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilkeshav27 anilkeshav27 anilkeshav27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jliempt @anilkeshav27 @Jk1484