Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add imagePushToRegistry step #4609

Merged
merged 78 commits into from
Nov 30, 2023
Merged

Conversation

anilkeshav27
Copy link
Member

@anilkeshav27 anilkeshav27 commented Oct 2, 2023

Changes

This PR adds a new imagePushToRegistry Golang step for copying docker images from one registry to another.

  • Tests
  • Documentation

@Jk1484 Jk1484 force-pushed the anil/ImagePushToRegistry branch 3 times, most recently from 811c7fc to 7ad867f Compare October 24, 2023 11:35
m1ron0xFF

This comment was marked as outdated.

@m1ron0xFF m1ron0xFF force-pushed the anil/ImagePushToRegistry branch from 403b37c to cc3df50 Compare November 15, 2023 10:09
@m1ron0xFF m1ron0xFF force-pushed the anil/ImagePushToRegistry branch from cc3df50 to d577ea8 Compare November 15, 2023 10:11
@vstarostin vstarostin requested review from Googlom and a team November 28, 2023 08:25
@vstarostin vstarostin requested a review from m1ron0xFF November 29, 2023 10:05
resources/metadata/imagePushToRegistry.yaml Show resolved Hide resolved
cmd/imagePushToRegistry.go Outdated Show resolved Hide resolved
cmd/imagePushToRegistry.go Outdated Show resolved Hide resolved
cmd/imagePushToRegistry.go Outdated Show resolved Hide resolved
cmd/imagePushToRegistry.go Outdated Show resolved Hide resolved
cmd/imagePushToRegistry.go Show resolved Hide resolved
cmd/imagePushToRegistry.go Show resolved Hide resolved
@m1ron0xFF
Copy link
Contributor

/it-go

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vstarostin
Copy link
Member

/it-go

@vstarostin vstarostin merged commit 8dc2a1b into master Nov 30, 2023
14 checks passed
@vstarostin vstarostin deleted the anil/ImagePushToRegistry branch November 30, 2023 09:06
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* imagePushToRegistry new step

* adding copy and push functionality

* including only copy correctly

* groovy step for imagePushToRegistry

* create .docker folder

* imagePushToRegistry new step

* adding copy and push functionality

* including only copy correctly

* groovy step for imagePushToRegistry

* create .docker folder

* fix CopyImage

* test

* test

* Correct docker config path

* Update

* Update

* Update

* Update

* Update

* Use creds from Vault

* Use creds from Vault

* Use creds from Vault

* Use creds from Vault

* Test

* Comment some logic

* Test: move regexp logic

* Test

* Update

* Update

* Clean up

* Update

* Update

* Update interface

* Rename function

* imagePushToRegistry: small refactoring (SAP#4688)

* imagePushToRegistry new step

* adding copy and push functionality

* including only copy correctly

* groovy step for imagePushToRegistry

* create .docker folder

* Correct docker config path

* Update

* Update

* Update

* Update

* Update

* Use creds from Vault

* Use creds from Vault

* Use creds from Vault

* Use creds from Vault

* Test

* Comment some logic

* Test: move regexp logic

* Test

* Update

* Update

* Clean up

* Update

* Update

---------

Co-authored-by: Keshav <[email protected]>
Co-authored-by: Muhammadali Nazarov <[email protected]>

* Update step yaml file

* Update interface

* Rename func

* Update tests

* Update interface, create mock methods, update tests

* Update mock

* Add md file

* Fix groovy doc, unit test, go unit test

* Update

* Add unit tests

* Support tagLatest param

* Fetch source creds from Vault

* Update yaml file

* Support multiple images

* Update test

* Support copy images in parallel

* Update yaml

* Clean up

* Return err if no creds provided

* Fix tests

* Add err msg

* Add debug log

* Do not use CPE for targetImages

* Support platform

* Delete Jenkins specific creds

* Update groovy: do not handle Jenkins creds

* Delete unused code

* Fix: Support platform

* Fix: Support platform

* Apply suggestion from code review

Co-authored-by: Egor Balakin <[email protected]>

* Apply suggestion from code review

Co-authored-by: Egor Balakin <[email protected]>

* Add tests for parseDockerImageName

* Add comment that tagArtifactVersion is not supported yet

* Set limit of running goroutines

* Fix: Set limit of running goroutines

* The tagArtifactVersion is not supported yet

---------

Co-authored-by: Muhammadali Nazarov <[email protected]>
Co-authored-by: Egor Balakin <[email protected]>
Co-authored-by: Vyacheslav Starostin <[email protected]>
Co-authored-by: Vyacheslav Starostin <[email protected]>
Co-authored-by: Egor Balakin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants