Making detect8 default script #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-kireev
approved these changes
Sep 18, 2023
CCFenner
reviewed
Sep 18, 2023
| @@ -297,22 +297,11 @@ spec: | |||
| - STAGES | |||
| - STEPS | |||
| deprecated: true | |||
| - name: useDetect8 | |||
| - name: useDetect7 | |||
There was a problem hiding this comment.
You could also have set this to true by default. This avoids a breaking change due to parameter naming.
There was a problem hiding this comment.
Thanks for the note! Returned old parameters as deprecated
|
/it-go |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/it-go |
daskuznetsova
pushed a commit
to daskuznetsova/jenkins-library
that referenced
this pull request
Oct 13, 2023
* made detect8 default * amended tests to reflect detect 8 * amended * amend * amend * amend tests * 1 * 1 * tests-with-temp-changes-for-transition * removed auto unmapping for detect7 * added-old-parameters-as-deprecated
andrew-kireev
pushed a commit
that referenced
this pull request
Oct 17, 2023
* made detect8 default * amended tests to reflect detect 8 * amended * amend * amend * amend tests * 1 * 1 * tests-with-temp-changes-for-transition * removed auto unmapping for detect7 * added-old-parameters-as-deprecated
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* made detect8 default * amended tests to reflect detect 8 * amended * amend * amend * amend tests * 1 * 1 * tests-with-temp-changes-for-transition * removed auto unmapping for detect7 * added-old-parameters-as-deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes