Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fixing documentation for violating markdownlint rules. #4559

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

Jk1484
Copy link
Contributor

@Jk1484 Jk1484 commented Sep 8, 2023

Changes

The markdown linting check is failing for PRs that trigger it. Fixing documentation for failing checks.

Removing unused links for violating MD053 rules.
Removing space between "*" and "Step" in abapEnvironmentAddons.md for violating MD037/no-space-in-emphasis rule.
Changing * to _ in neoDeploy.md for violating MD049/emphasis-style rule.
Fixing links in transportRequestUploadSOLMAN.md:10 and abapEnvironment/configuration.md:134

  • Tests
  • Documentation

@Jk1484 Jk1484 requested review from a team as code owners September 8, 2023 07:12
@Jk1484
Copy link
Contributor Author

Jk1484 commented Sep 8, 2023

/it-go

Copy link
Member

@CCFenner CCFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CCFenner
Copy link
Member

CCFenner commented Sep 8, 2023

Thanks, looks good!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CCFenner CCFenner merged commit bbf9122 into master Sep 8, 2023
@CCFenner CCFenner deleted the muhammadali.DocumentationFix branch September 8, 2023 10:07
daskuznetsova pushed a commit to daskuznetsova/jenkins-library that referenced this pull request Oct 13, 2023
…P#4559)

* fix(docs): fixing documentation for violating markdownlint rules.

* correct indent

* Apply suggestions from code review

* correct list

---------

Co-authored-by: Christopher Fenner <[email protected]>
andrew-kireev pushed a commit that referenced this pull request Oct 17, 2023
)

* fix(docs): fixing documentation for violating markdownlint rules.

* correct indent

* Apply suggestions from code review

* correct list

---------

Co-authored-by: Christopher Fenner <[email protected]>
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
…P#4559)

* fix(docs): fixing documentation for violating markdownlint rules.

* correct indent

* Apply suggestions from code review

* correct list

---------

Co-authored-by: Christopher Fenner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants