Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kanikoExecute): remove STAGES scope from multipleImages param #4508

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

m1ron0xFF
Copy link
Contributor

@m1ron0xFF m1ron0xFF commented Aug 11, 2023

Changes

kanikoExecute.multipleImages is not supposed to be configured from STAGES scope.
one of our users encountered a regression using latest (master) Piper version.

  • Tests
  • Documentation

@m1ron0xFF m1ron0xFF requested a review from a team as a code owner August 11, 2023 07:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vstarostin
Copy link
Member

/it-go

@LindaSieb
Copy link
Member

Could you put why you're doing this in the description of this PR? That makes it easier for the rest of us seeing this, and if we look back we'll remember why we did it 🙂

@m1ron0xFF m1ron0xFF merged commit 9189ab3 into master Aug 11, 2023
@m1ron0xFF m1ron0xFF deleted the mironoff/fix-multi-images-scopes branch August 11, 2023 09:31
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants