fix(golangBuild): BOM creation failed with private Go modules #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jliempt
commented
Jul 31, 2023
There was a problem hiding this comment.
I just realised it's maybe not a great idea to use the host URLs in git config instead of the specific repository URLs. Because it could potentially lead to confusion in other parts of the step when git is needed.
But if we do go ahead with the host URLs, maybe they can be parsed from the privateModules parameter instead of iterating over go.mod?
jliempt
commented
Aug 7, 2023
|
/it-go |
jliempt
commented
Aug 9, 2023
|
/it-go |
jliempt
commented
Aug 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
aibaend1
approved these changes
Aug 14, 2023
|
/it-go |
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* quickly try to only specify base private repo URLs with git config * fix the test * refactoring of private modules * test * fix test * fix url * typo * Adding gitConfiguration * typo * unit test * unit test --------- Co-authored-by: I557621 <[email protected]> Co-authored-by: aibaend1 <[email protected]> Co-authored-by: asadu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CycloneDX uses a
go listcommand which needs git to authenticate to the base URL of private modules.Since
git config'sinsteadOfuses a base URL, I think we can replace thegit configcommands that we do in this step for all individual private modules with just the base URLs.Since GOPRIVATE can be in glob format, we can't use the
privateModulesparameter directly to determine the base URLs.Changes