feat (url-logger) Implement logic for a selection classifier #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilkeshav27
commented
Jun 16, 2023
There was a problem hiding this comment.
i dont think we need these changes for other steps, since the url log is only needed for build related steps.
if we implement it for other steps it may overwrite the existing url-log.json . i would restrict it to only npmExecuteScripts, mavenBuild, golangBuild, pythonBuild, kanikoExecute, helmExecute, gradleBuild, mtaBuild
added 5 commits
June 19, 2023 12:08
|
/it-go |
|
Kudos, SonarCloud Quality Gate passed!
|
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* forcing the urls finder to relaxed * adding a classifier map * passing the stepName to the kaniko command executor bundle * pass stepName to maven utils for mavenBuild * improve enabling of Maven access log generation * Revert "improve enabling of Maven access log generation" This reverts commit 80b7722. * Revert "pass stepName to maven utils for mavenBuild" This reverts commit a4f99ae. * use reflection to update command stepName for mavenBuild * Revert "use reflection to update command stepName for mavenBuild" This reverts commit ef85c78. --------- Co-authored-by: I557621 <[email protected]> Co-authored-by: Jordi van Liempt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the access log (
url-log.json) generation for golangBuild and kanikoExecute. For golangBuild, a selection classifier is added to make the URL detection less strict so that URLs without a protocol are also considered.