fix(codeqlExecuteScan): added waiting for the SARIF file upload #4409
+244
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a/jenkins-library into codeql-sarif-upload
vlkl-sap
requested changes
Jun 16, 2023
…a/jenkins-library into codeql-sarif-upload
vlkl-sap
requested changes
Jun 19, 2023
| @@ -104,6 +104,22 @@ spec: | |||
| - STAGES | |||
| - STEPS | |||
| default: false | |||
| - name: sarifCheckMaxRetries | |||
| type: int | |||
| description: "Sets max retries for check SARIF file is uploaded when server doesn't response." | |||
There was a problem hiding this comment.
I propose: "Maximum number of retries when waiting for the server to finish processing the SARIF upload. Only relevant, if checkForCompliance is enabled."
sumeetpatil
reviewed
Jun 20, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
sumeetpatil
approved these changes
Jun 20, 2023
|
/it |
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
…4409) * added waiting for the sarif file uploaded & tests * increased polling time, added timeout for waiting response from server & tests * fixed handling error while waiting sarif uploaded * added params for checking sarif uploaded & refactor * added test logs * fixed logs and test * added returning missed error * changed params descriptions and server response error processing processing * fixed retrying logic * increased polling timeout params & refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added waiting for the SARIF to upload before calling code-scanning APIs.
After scanning, the SARIF file is created, which must be uploaded to github. The codeql github upload-results command returns the URL of the SARIF file. This URL checks the status of the upload.