Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(whitesourceExecuteScan): allow to specify InstallCommand #4376

Merged
merged 4 commits into from
May 30, 2023

Conversation

Exotrom
Copy link
Contributor

@Exotrom Exotrom commented May 25, 2023

Changes

Add the currently documented but not yet implemented InstallCommand option for the whitesourceExecuteScan step in order to execute an additional command before running the mend scan.

This might be helpful if some manual preparation for the scan is required, e.g. copying a pipeline-specific .npmrc file for the mend scan.

  • Tests
  • Documentation

@cla-assistant
Copy link

cla-assistant bot commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

@Exotrom Exotrom marked this pull request as ready for review May 25, 2023 08:50
@Exotrom Exotrom requested a review from a team as a code owner May 25, 2023 08:50
@Exotrom Exotrom changed the title feat(whitesourceExecuteScan) allow to specify InstallCommand feat(whitesourceExecuteScan): allow to specify InstallCommand May 25, 2023
@sumeetpatil sumeetpatil requested a review from andrew-kireev May 30, 2023 06:30
cmd/whitesourceExecuteScan_test.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sumeetpatil
Copy link
Member

/it

@andrew-kireev andrew-kireev merged commit c15448b into SAP:master May 30, 2023
@Exotrom Exotrom deleted the ws-install-command branch June 6, 2023 12:53
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* feat(whitesourceExecuteScan) allow to specify InstallCommand

* reorder imports

---------

Co-authored-by: sumeet patil <[email protected]>
Co-authored-by: Andrei Kireev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants