fix(golangBuild): pinversion of cyclonedx #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashlymat
reviewed
May 22, 2023
cmd/golangBuild.go
Outdated
| @@ -570,7 +570,7 @@ func lookupGolangPrivateModulesRepositories(goModFile *modfile.File, globPattern | |||
| } | |||
|
|
|||
| func runBOMCreation(utils golangBuildUtils, outputFilename string) error { | |||
| if err := utils.RunExecutable("cyclonedx-gomod", "mod", "-licenses", "-test", "-output", outputFilename); err != nil { | |||
| if err := utils.RunExecutable("cyclonedx-gomod", "mod", "-licenses", "-test", "-output", outputFilename, "-ouput-version", "1.4"); err != nil { | |||
There was a problem hiding this comment.
I see a typo here ouput-version
It should be "output-version"
@Jk1484 , could you please also test changes before marking it for review?
There was a problem hiding this comment.
could you please also test changes before marking it for review?
That would be great since there are people using this :(
Jk1484
force-pushed
the
muhammadali.GolangBuildVersionPin
branch
from
1451021 to
610096e
Compare
|
@Jk1484, I think unit tests should be fixed/updated. |
vstarostin
approved these changes
May 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
/it-go |
2 tasks
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* output version pin for cyclonedx * test fix --------- Co-authored-by: Vyacheslav Starostin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pin output version of cyclonedx to 1.4