Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codeqlExecuteScan): fixed regexp pattern to correctly parse ssh url #4349

Merged
merged 3 commits into from
May 5, 2023
Merged

fix(codeqlExecuteScan): fixed regexp pattern to correctly parse ssh url #4349

merged 3 commits into from
May 5, 2023

Conversation

daskuznetsova
Copy link
Contributor

@daskuznetsova daskuznetsova commented May 5, 2023 •
edited
Loading

Fixed pattern to correctly parse url with both https and ssh scheme.

  • Tests
  • Documentation

@daskuznetsova daskuznetsova requested a review from a team as a code owner May 5, 2023 14:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

vlkl-sap
vlkl-sap approved these changes May 5, 2023
View reviewed changes
Copy link

@vlkl-sap vlkl-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It would have been more convenient to factor out utility methods for these tests, but that's something we can save for the next time we touch that code. Otherwise, LGTM.

@vlkl-sap
Copy link

vlkl-sap commented May 5, 2023

/it

1 similar comment
@sumeetpatil
Copy link
Member

/it

@sumeetpatil sumeetpatil merged commit 7de6f38 into SAP:master May 5, 2023
@daskuznetsova daskuznetsova deleted the codeql-regexp branch June 20, 2023 12:51
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@daskuznetsova @maxatsap
fix(codeqlExecuteScan): fixed regexp pattern to correctly parse ssh u…
3d6fae2 
…rl (SAP#4349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlkl-sap vlkl-sap vlkl-sap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskuznetsova @vlkl-sap @sumeetpatil