Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update CODEOWNERS for credentialdiggerScan step #4348

Merged
merged 7 commits into from
Jan 10, 2024
Merged

chore: Update CODEOWNERS for credentialdiggerScan step #4348

merged 7 commits into from
Jan 10, 2024

Conversation

marcorosa
Copy link
Member

Changes

  • Documentation

Update CODEOWNERS for credentialdiggerScan step

@marcorosa marcorosa requested review from phil9909 and a team as code owners May 5, 2023 12:33
ashlymat
ashlymat reviewed May 8, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
ashlymat
ashlymat reviewed May 12, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
ashlymat
ashlymat reviewed May 12, 2023
View reviewed changes
.github/CODEOWNERS
@@ -63,6 +63,9 @@ AbapEnvironment* @SAP/jenkins-library-abap
ascAppUpload* @Mau04 @inf2381
AscAppUpload* @Mau04 @inf2381

credentialdiggerScan* @SAP/credential-digger-members @SAP/credential-digger-admins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CCFenner @OliverNocon ,probably Marco and Slim needs write permissions? https://github.com/orgs/SAP/teams/credential-digger-admins

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I see the team has been created (not by me, so thanks to who did it :D )
I think we can leave @SAP/credential-digger-admins without members (unless you prefer to have both, but I don't get the difference in that case). And anyway it's always Slim and me

@ashlymat
Copy link
Member

/it-go

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Jul 22, 2023
@marcorosa
Copy link
Member Author

Hi @ashlymat I see this is still open and moved to stale, but I had a doubt that went maybe unnoticed.

From my message of 12/05:
Hi, I see the team has been created (not by me, so thanks to who did it :D )
I think we can leave @SAP/credential-digger-admins without members (unless you prefer to have both, but I don't get the difference in that case). And anyway it's always Slim and me

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Jul 27, 2023
@marcorosa
Copy link
Member Author

Hi @SAP/jenkins-library-admin

gentle reminder for the following request:

Hi, I see the team has been created (not by me, so thanks to who did it :D )
I think we can leave https://github.com/orgs/SAP/teams/credential-digger-admins without members (unless you prefer to have both, but I don't get the difference in that case). And anyway it's always Slim and me

@github-actions
Copy link
Contributor

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Oct 28, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marcorosa
Copy link
Member Author

@SAP/jenkins-library-admin please note this PR only adds the codeowners of a step and it's open since 6 months. If it goes stale again, I will not reopen it for a 3rd time.

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Nov 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added stale marks stale issues and pull requests and removed stale marks stale issues and pull requests labels Jan 1, 2024
@CCFenner CCFenner changed the title Update CODEOWNERS for credentialdiggerScan step chore: Update CODEOWNERS for credentialdiggerScan step Jan 10, 2024
CCFenner
CCFenner approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@CCFenner CCFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@CCFenner CCFenner merged commit 6ac8fd1 into SAP:master Jan 10, 2024
11 checks passed
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@marcorosa @ashlymat
@CCFenner @maxatsap
chore: Update CODEOWNERS for credentialdiggerScan step (SAP#4348)
0a31212 
* Update CODEOWNERS for credentialdiggerScan step

* Update .github/CODEOWNERS

* Update .github/CODEOWNERS

---------

Co-authored-by: Ashly Mathew <[email protected]>
Co-authored-by: Ashly Mathew <[email protected]>
Co-authored-by: Christopher Fenner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashlymat ashlymat ashlymat left review comments

@CCFenner CCFenner CCFenner approved these changes

@phil9909 phil9909 Awaiting requested review from phil9909

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcorosa @ashlymat @CCFenner